-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
datamodel: create base structure for datamodel #15
Conversation
90b8fa4
to
adae01c
Compare
NOTE*: I think both commits can be squashed in one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great for setting up the groundwork on which to build the different schema fields.
Co-authored-by: Guillaume Viger <fenekku@fenekku.com>
@fenekku addressed all your comments :) Thanks a lot! Just reminds the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good. The last 2 things for me are:
- title sorting (let's take care of it now) + suggesting: what is the use case for title auto-completion (when are we doing this?)?
- the
date
/date-time
usage for publication_date : why different?
I will approve, so once you resolve them you can merge.
7f06542
to
97098a3
Compare
Create a base structure for the DataCite based datamodel. This aligns with the
records
datamodel insidecookiecutter-invenio-instance
(previously self-contained incookiecutter-invenio-datamodel
).It contains:
NOTE: There's still a lot of discussion to be had on what should be internal and what metadata, etc. This just aims to have a clear code structure of the datamodel and a starting point to add more fields.
Closes #6