Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datamodel: create base structure for datamodel #15

Merged
merged 5 commits into from
Oct 22, 2019

Conversation

ppanero
Copy link
Member

@ppanero ppanero commented Oct 16, 2019

Create a base structure for the DataCite based datamodel. This aligns with the records datamodel inside cookiecutter-invenio-instance (previously self-contained in cookiecutter-invenio-datamodel).

It contains:

  • JSON Schemas
  • Elasticsearch mappings
  • Loaders
  • Serializers
  • Deserializers

NOTE: There's still a lot of discussion to be had on what should be internal and what metadata, etc. This just aims to have a clear code structure of the datamodel and a starting point to add more fields.

Closes #6

@ppanero
Copy link
Member Author

ppanero commented Oct 17, 2019

NOTE*: I think both commits can be squashed in one

Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great for setting up the groundwork on which to build the different schema fields.

invenio_rdm_records/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/config.py Show resolved Hide resolved
invenio_rdm_records/config.py Outdated Show resolved Hide resolved
invenio_rdm_records/ext.py Outdated Show resolved Hide resolved
invenio_rdm_records/marshmallow/json.py Show resolved Hide resolved
invenio_rdm_records/marshmallow/json.py Show resolved Hide resolved
invenio_rdm_records/static/templates/records/results.html Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
tests/test_examples_app.py Show resolved Hide resolved
Co-authored-by: Guillaume Viger <fenekku@fenekku.com>
@ppanero
Copy link
Member Author

ppanero commented Oct 18, 2019

@fenekku addressed all your comments :) Thanks a lot!

Just reminds the keyword. I would create an issue and leave as it is for now, to be consistent with cookiecutter (which was the point of the issue). And have a further discussion on the keywords/subjetc(s)/etc. and change as a result in the future. What do you think?

@ppanero ppanero requested a review from fenekku October 18, 2019 09:35
Copy link
Contributor

@fenekku fenekku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. The last 2 things for me are:

  • title sorting (let's take care of it now) + suggesting: what is the use case for title auto-completion (when are we doing this?)?
  • the date / date-time usage for publication_date : why different?

I will approve, so once you resolve them you can merge.

@ppanero ppanero force-pushed the datamodel branch 4 times, most recently from 7f06542 to 97098a3 Compare October 21, 2019 14:06
@ppanero ppanero merged commit d8c1eb1 into inveniosoftware:master Oct 22, 2019
@ppanero ppanero deleted the datamodel branch October 22, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align codebase with cookiecutter-invenio-instance
2 participants