deposit-ui: fix deposit form infinite recursion #1891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* This can help with debugging unexpected non-network related errors that might occur in the logic before/after a REST API requests.
* This initial removal of empty values can be dangerous, since the `record` at this point is a UI object representation that could potentially include circular references or very deeply nested objects. Since `_removeEmptyValues` is recursive this can lead to stack overflow errors.
slint
changed the title
zzacharo
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deposit-ui: log errors on all deposit form actions
that might occur in the logic before/after a REST API requests.
deposit-ui: skip unecessary removal of empty values in serialization
recordat this point is a UI object representation that couldpotentially include circular references or very deeply nested objects.
Since
_removeEmptyValuesis recursive this can lead to stackoverflow errors.