models: avoid flushing when getting records

invenio_users_resources/records/api.py

@@ -189,9 +189,10 @@ def from_user(cls, user):
         # TODO
         data = parse_user_data(user)
 
-        model = cls.model_cls(data, model_obj=user)
-        user_agg = cls(data, model=model)
-        return user_agg
+        with db.session.no_autoflush:
+            model = cls.model_cls(data, model_obj=user)
+            user_agg = cls(data, model=model)
+            return user_agg
 
     @classmethod
     def get_record(cls, id_):
@@ -278,10 +279,11 @@ def from_role(cls, role):
         # TODO
         data = parse_role_data(role)
 
-        model = cls.model_cls(data, model_obj=role)
-        role_agg = cls(data, model=model)
-        role_agg._role = role
-        return role_agg
+        with db.session.no_autoflush:
+            model = cls.model_cls(data, model_obj=role)
+            role_agg = cls(data, model=model)
+            role_agg._role = role
+            return role_agg
 
     @classmethod
     def get_record(cls, id_):

invenio_users_resources/services/users/service.py

@@ -77,7 +77,7 @@ def create(self, identity, data, raise_errors=True, uow=None):
         )
 
     def search(self, identity, params=None, search_preference=None, **kwargs):
-        """Search for records matching the querystring."""
+        """Search for active and confirmed users, matching the querystring."""
         return super().search(
             identity,
             params=params,