Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX improvements #193

Merged
merged 1 commit into from
Sep 15, 2020
Merged

UX improvements #193

merged 1 commit into from
Sep 15, 2020

Conversation

FlorianCassayre
Copy link
Member

@FlorianCassayre FlorianCassayre commented Sep 11, 2020 •
edited
Loading

image

image

@FlorianCassayre FlorianCassayre changed the title Fixed dynamic links UX improvements Sep 11, 2020
@FlorianCassayre
Copy link
Member Author

The selection input can be improved even further by converting the HitsSearch component into a Dropdown. Would work for both single and multiple selections.

@FlorianCassayre FlorianCassayre force-pushed the html-links branch 2 times, most recently from 2d11190 to 06aef67 Compare September 14, 2020 08:09
@FlorianCassayre
UX improvements and refactoring
85afad7 
* fixed dynamic links
* fixed some react errors
* ESSelector improved UX
* refactoring (using the dedicated icon components when possible)
ntarocco
ntarocco approved these changes Sep 14, 2020
View reviewed changes
Copy link
Contributor

@ntarocco ntarocco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes!
A good UI would be that we have:

Searching:

searching

Selected:

selected

@FlorianCassayre
Copy link
Member Author

Yep, I was thinking the same. Currently only the Dropdown component is able to display labels inside the input, but it has its own search mechanism and I'm not sure if we can combine it with the Search component.

@kpsherva kpsherva mentioned this pull request Sep 15, 2020
Open
@kpsherva kpsherva merged commit 84be419 into inveniosoftware:master Sep 15, 2020
@kpsherva kpsherva added this to the 2020/W36 milestone Sep 16, 2020
@FlorianCassayre FlorianCassayre mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntarocco ntarocco ntarocco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2020/W36
Development

Successfully merging this pull request may close these issues.

Frontsite: cannot open documents in a new tab
3 participants
@FlorianCassayre @ntarocco @kpsherva