Landing map #527
Open
Landing map #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if no users are on the map, display former recent public items I would be fine to remove completly recent public items if this commit if to confusing for the user The idea was to always display some items on the landing page, but is the search location does not return any user, it could be confusing to still display some books at the same location but that are not connected to the map bbox anymore
…nge it 3advantages to this decision: 1/ simplify the interface by not displaying inventory display switch 2/ do not display owner username on each item (which cascade does) 3/ give the user an overview of the two ways to display items
and DRY other occurences inside a dedicated UserInfobox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the landing page to have a map of current users and groups.
Users on the map have a sample of their public group displayed below the map. If no items can be displayed, a list of recent items is displayed (aka the display before this PR).
When clicking on markers, the full list of the public items is shown in a modal (which is preferred compared to navigating to the group or user profile, in order to not extract from the map context).
Additionally to a nominatim finder, one may "geolocate" on the map.
Solves #295
TODO post decentralisation: put
landingPageMapPositionin config