Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR] User registration via API #3978

Closed
4 tasks done
matmair opened this issue Nov 21, 2022 · 5 comments · Fixed by #4187
Closed
4 tasks done

[FR] User registration via API #3978

matmair opened this issue Nov 21, 2022 · 5 comments · Fixed by #4187
Assignees
@matmair
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature security Relates to a security issue
Milestone
0.12.0

Comments

@matmair
Copy link
Member

matmair commented Nov 21, 2022 •
edited
Loading

Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

Problem statement

We currently do not support user registration via API - so the frontend must be used

Suggested solution

Steps:

  • Add an API endpoint under /api/user/register to registering users
  • Add unit testing for it

Describe alternatives you've considered

N/A

Examples of other systems

No response

Do you want to develop this?

  • I want to develop this.
@matmair matmair added enhancement This is an suggested enhancement or new feature triage:not-checked Item was not checked by the core team labels Nov 21, 2022
@matmair matmair self-assigned this Nov 21, 2022
@matmair matmair added this to the 0.10.0 milestone Nov 21, 2022
@matmair matmair added api Relates to the API security Relates to a security issue and removed triage:not-checked Item was not checked by the core team labels Nov 21, 2022
@matmair
Copy link
Member Author

matmair commented Nov 21, 2022

Ref #3901

@matmair matmair mentioned this issue Nov 21, 2022
Closed
12 tasks
@geniesis
Copy link
Contributor

It might be valuable to add SCIM 2.0 support when developer this api endpoint, this would allow just in time provisioning with SSO providers.

@matmair
Copy link
Member Author

matmair commented Nov 29, 2022

@geniesis this FR is limited to registration via a single API endpoint - providing the same functionality via REST that is given via the current web UI.
Please open an FR if you want SCIM - that is a more involved request than a single endpoint and is an enterprise feature.

matmair added a commit to matmair/InvenTree that referenced this issue Jan 9, 2023
@matmair
Add dj-rest-auth
e32e5ba 
[FR] User registration via API
Fixes inventree#3978
@matmair matmair mentioned this issue Jan 9, 2023
Merged
4 tasks
@SchrodingersGat SchrodingersGat modified the milestones: 0.10.0, 0.11.0 Feb 2, 2023
@SchrodingersGat SchrodingersGat modified the milestones: 0.11.0, 0.12.0 Apr 12, 2023
@SchrodingersGat SchrodingersGat mentioned this issue Jun 3, 2023
Closed
@matmair matmair moved this to In Progress in User Interface Redesign Jun 3, 2023
matmair added a commit to matmair/InvenTree that referenced this issue Jun 8, 2023
@matmair
[FR] User registration via API
830cc5a 
Fixes inventree#3978
@SchrodingersGat
Copy link
Member

@matmair any objection to me bumping this from 0.12.0 release?

@matmair
Copy link
Member Author

matmair commented Jun 12, 2023

@SchrodingersGat I would really prefer to get it in there as we can not move the login/signup UI to #5011 without the APIs.

SchrodingersGat pushed a commit that referenced this issue Jun 20, 2023
@matmair
Add dj-rest-auth (#4187)
b700b44 
* Add dj-rest-auth
[FR] User registration via API
Fixes #3978

* add jwt support for API

* check for old password

* Add check if registration is allowed

* make email mandatory if selected

* lower postgres version?

* update req

* revert psql change

* move form options out

* Update reqs

* Add handlers for most OAuth2

* refactor and add logging

* make error message more actionable

* add handler for twitter

* add keycloak endpoint

* warning for legacy apps

* remove legacy twitter support

* rename file

* move url to sub

* make JWT optional (default off)

* Add var to config template

* Add API endpoint to list available providers

* fix url pattern
@github-project-automation github-project-automation bot moved this from In Progress to Done in User Interface Redesign Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matmair matmair

Labels
api Relates to the API enhancement This is an suggested enhancement or new feature security Relates to a security issue
Projects
User Interface Redesign
Status: Done
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

Add dj-rest-auth matmair/InvenTree
3 participants
@SchrodingersGat @geniesis @matmair