-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add setups / OOBE #2947
Conversation
@SchrodingersGat would you mind taking a look at the syntax for the setup files in this sample file? Not all functions are done rn; Namely missing is the data action at the end.
|
@matmair I'm away for the weekend, will jump on this first thing next week :) |
- Test various failure modes - Some of the failure modes didn't fail - this is also a failure - Fixing API code accordingly
- Sample plugin now updates metadata tag
81241c4
to
6cbbcf7
Compare
953a52a
to
f461721
Compare
f461721
to
b7234df
Compare
@matmair nice approach here. Given that we are going to start thinking about moving away from server-side rendering and to a frontend framework, should we concentrate more heavily on using the API? I'm reluctant to introduce more server-rendered forms, if we are going to subsequently have to refactor.. What do you think? |
@SchrodingersGat I imagine the switch to be staggered. First all user-frontend, than the admin-frontend. I would like to leave /auth, /admin and /setup in pure django fashion as security with react can sometimes be a bit tricky but if we have some django base sites we can start a session there and embed a ultra-shortlived session token in the browser and use that for auth instead of tokens that work for days and are saved in the browser. Also the admin stuff does not need to be fancy in my opinion. |
Missing:
|
…matmair/issue2284
This PR implements setups as first class citizens. This required for the OOBE and setups in general.
Closes #2284