Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add setups / OOBE #2947

Closed
wants to merge 54 commits into from
Closed

Conversation

matmair
Copy link
Member

@matmair matmair commented May 8, 2022

This PR implements setups as first class citizens. This required for the OOBE and setups in general.

Closes #2284

@matmair matmair added this to the 0.8.0 milestone May 9, 2022
@matmair
Copy link
Member Author

matmair commented May 9, 2022

@SchrodingersGat would you mind taking a look at the syntax for the setup files in this sample file?

Not all functions are done rn; Namely missing is the data action at the end.
There are a few built-in limitations:

  • no i18n included - or planned
  • only a few specified inputs can be used
  • no cross-session state saving - this is only implemented in-session as the whole framework also works without a database (initial setup for example)

@SchrodingersGat
Copy link
Member

@matmair I'm away for the weekend, will jump on this first thing next week :)

@matmair matmair force-pushed the matmair/issue2284 branch from 81241c4 to 6cbbcf7 Compare May 18, 2022 21:47
@matmair matmair force-pushed the matmair/issue2284 branch from 953a52a to f461721 Compare May 18, 2022 21:56
@matmair matmair force-pushed the matmair/issue2284 branch from f461721 to b7234df Compare May 18, 2022 22:02
@SchrodingersGat
Copy link
Member

@matmair nice approach here. Given that we are going to start thinking about moving away from server-side rendering and to a frontend framework, should we concentrate more heavily on using the API?

I'm reluctant to introduce more server-rendered forms, if we are going to subsequently have to refactor.. What do you think?

@matmair
Copy link
Member Author

matmair commented May 19, 2022

@SchrodingersGat I imagine the switch to be staggered. First all user-frontend, than the admin-frontend. I would like to leave /auth, /admin and /setup in pure django fashion as security with react can sometimes be a bit tricky but if we have some django base sites we can start a session there and embed a ultra-shortlived session token in the browser and use that for auth instead of tokens that work for days and are saved in the browser.

Also the admin stuff does not need to be fancy in my opinion.

@matmair
Copy link
Member Author

matmair commented May 19, 2022

Missing:

  • finishing action (yaml)
  • next setup options (yaml)
  • issue event after setup
  • SetupRun model
  • first startup flag
  • settings field (forms)
  • built-in setups for config file and use-case

@matmair matmair marked this pull request as ready for review May 19, 2022 23:21
@matmair matmair closed this May 19, 2022
@matmair matmair reopened this May 19, 2022
@matmair matmair marked this pull request as draft May 19, 2022 23:21
@matmair matmair closed this May 25, 2022
@matmair matmair deleted the matmair/issue2284 branch May 25, 2022 20:04
@matmair matmair mentioned this pull request Jun 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] settings setup guide / OOBE
3 participants