Part pricing cache #3710
Merged
Part pricing cache #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently this model does not "do" anything but will be used for caching pre-calculated pricing information
SchrodingersGat
added
enhancement
matmair
reviewed
Sep 23, 2022
Which fields would you cull? How do you see the caching functionality working here? |
…Tree into part-pricing-cache
- Updated model with new fields - Code for calculating BOM price - Code for calculating internal price - Code for calculating supplier price - Updated unit testing
- Adds helper function for formatting currency data - No longer pre-render "price strings" on the server
- Caching across mnultiple processes causes issues - Need to move to something like redis to solve this - Ref: inventree#3921
- Consistent naming
matmair
approved these changes
Nov 13, 2022
There was a problem hiding this comment.
@SchrodingersGat looks good from my side.
Still wondering if code duplication could be reduced with the different types of pricing (esp. in API urls, forms)
|
Not really sure if it solves #3553 fully |
|
@SchrodingersGat i think the idea was originally to make a toggle as we also had an FR to reduce the number of shown decimal places. |
- Take unit pricing / pack size into account
- Use unit pricing (take pack size into account)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR represents the first steps towards a major overhaul of pricing.
Currently, part pricing is too expensive to calculate "on the fly" and causes issues with viewing prices in a Bill of Materials, for example.
The major goal of this PR is to add a new database model which stores cached pricing information for a Part. This pricing information can be used in API requests for fast lookup against multiple parts.
Individual "quantity pricing" for a single part will still need to be calculated "on the fly" but for a single part should not be too expensive.
TODO
Schedule update when part is created / edited / deletedhas_complete_bom_pricingmethodFuture Work
get_price_infomethodget_bom_price_rangemethodget_price_rangemethodReferences