-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FR] Slack notifications & notification method updates #4114
Conversation
Add slack sending method Fixes inventree#3843
@matmair: I just stumbled on this package again. Have used it earlier (CLI only) for Gotify. However, it may give the possibility of having general notifications, without explicitly adding every service independently.. |
@miggland looks cool, I created a new FR for it. While it is easy to send simple notifications I prefer to use native integrations as they allow for the use of platform-specific features (like Slack Block Kit for example). |
@SchrodingersGat I would have loved a simple one-click add button for setup but that would require me publishing a central app for slack (and therefore everyone trusting me not screwing with that access). Not sure if everything Lukas envisioned is covered, I think we should let him decide. @wolflu05 |
@matmair Sorry, didn't get the context why you mentioned me. Or do you mean the new settings content mixin which gets added by this pr which is not included in the title? Form my side, I would preferre an interface more like the panels mixin which also adds the ability to render custom js templates directly and also render html templates via filename. I know this could be made already via some custom logic, but I think I'm not the only one which will try to add custom templates instead of html strings. |
@wolflu05 yeah you were mentioned for that / #4073 |
@matmair nice work. A small docs PR would be great if you have a chance |
Yeah, the whole Django rendering part with templates, plugins provide will be tricky in the react ui. Maybe it can be just embedded via iframes? |
@wolflu05 there are some limitations with iframes from browsers so I am still trying to find another way. |
@matmair from what limitations are you talking? |
@wolflu05 some APIs can not be called by js code in an iframe. |
@matmair And what about using dangerouslysetinnerhtml for legacy plugins, and current plugins can just provide an bundle file which has a default export which is included via runtime import() and rendered as component? |
This PR:
- [ ] Extends notification methods to include registeringFixes #3843