-
-
Notifications
You must be signed in to change notification settings - Fork 815
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove django-allauth-2fa, dj-rest-auth and django-user-sessions #6293
base: master
Are you sure you want to change the base?
Conversation
❌ Deploy Preview for inventree-web-pui-preview failed.
|
…matmair/issue6281
…matmair/issue6281
@sur5r this re-implements the MFA stack and now keeps the user completely in PUI. It is not fully done but I would appreciate if you could test this and report back. Please do this on a test-database, we are migrating the factors to a new DB schema so there could be issues. |
Will do, but might take some days before I get around to it. @matmair could pass by at PoC desk if you have time? |
@sur5r which PoC desk? |
At 38c3, first floor. https://38c3.c3nav.de/l/c:1:193.66:143.06/ |
…matmair/issue6281
…matmair/issue6281
This PR remove django-allauth-2fa and replaces it with the inline functions of django-allauth. This reduces the depenecdy footprint and sets us up for further improvements that are planned upstream. Those will reduce the dependency footprint even more and close #4002
Update: Most of the planned things we would be interested in are now implemented and the scope shifted a bit - it makes sense to just ripp all auth extensions out and use only allauths built-in things. We have a lot of grown auth-adjencent code that can probably be removed / rewritten.
Closes #6281
Todo: