Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Currency format fix #7398

Merged
merged 2 commits into from
Jun 4, 2024
Merged

Currency format fix #7398

merged 2 commits into from
Jun 4, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Catch edge case in currency rendering
  • Add validators for settings values

@SchrodingersGat
Fix for currency rendering
7342104 
- Handle case where max digits less than min digits
@SchrodingersGat
Add validators for settings
16bc45c
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface backport Apply this label to a PR to enable auto-backport action Platform UI Related to the React based User Interface backport-to-0.15.x labels Jun 3, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Jun 3, 2024
@netlify Netlify
Copy link

netlify bot commented Jun 3, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 16bc45c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/665e51b5a62d55000851671c
😎 Deploy Preview https://deploy-preview-7398--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (0cb762d) to head (16bc45c).
Report is 328 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/common/validators.py 72.41% 8 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7398      +/-   ##
==========================================
+ Coverage   83.80%   83.82%   +0.02%     
==========================================
  Files        1054     1055       +1     
  Lines       46255    46276      +21     
  Branches     1390     1390              
==========================================
+ Hits        38762    38789      +27     
+ Misses       7131     7123       -8     
- Partials      362      364       +2
Flag Coverage Δ
backend 85.15% <73.33%> (+<0.01%) ⬆️
pui 65.38% <ø> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit a5fa5f8 into inventree:master Jun 4, 2024
32 of 33 checks passed
@SchrodingersGat SchrodingersGat deleted the currency-format-fix branch June 4, 2024 00:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 4, 2024

💔 All backports failed

Status Branch Result
❌ 0.15.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 7398

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

martonmiklos pushed a commit to martonmiklos/InvenTree that referenced this pull request Jun 24, 2024
@SchrodingersGat @martonmiklos
Currency format fix (inventree#7398)
c41dac1 
* Fix for currency rendering

- Handle case where max digits less than min digits

* Add validators for settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
1 participant
@SchrodingersGat