Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test result choices #7417

Merged
merged 10 commits into from
Jun 8, 2024

Conversation

SchrodingersGat
Copy link
Member

  • Adds "choices" field to PartTestTemplate model
  • Allows user to specify set of "valid" values for a particular StockItemTestResult
  • UI updates also

@SchrodingersGat SchrodingersGat added enhancement This is an suggested enhancement or new feature stock Related to Stock models api Relates to the API labels Jun 7, 2024
@SchrodingersGat SchrodingersGat added this to the 0.16.0 milestone Jun 7, 2024
Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 6fd4ddd
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6663951354eb040008d05f54
😎 Deploy Preview https://deploy-preview-7417--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 89 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Jun 8, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 9 lines in your changes missing coverage. Please review.

Project coverage is 83.82%. Comparing base (3ecbd64) to head (6fd4ddd).
Report is 339 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/forms/StockForms.tsx 43.75% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7417      +/-   ##
==========================================
- Coverage   83.83%   83.82%   -0.02%     
==========================================
  Files        1056     1056              
  Lines       46341    46335       -6     
  Branches     1391     1394       +3     
==========================================
- Hits        38851    38838      -13     
- Misses       7122     7129       +7     
  Partials      368      368              
Flag Coverage Δ
pui 65.54% <52.63%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit a90b05a into inventree:master Jun 8, 2024
27 of 28 checks passed
@SchrodingersGat SchrodingersGat deleted the test-result-choices branch June 8, 2024 01:21
martonmiklos pushed a commit to martonmiklos/InvenTree that referenced this pull request Jun 24, 2024
* Add "choices" field to PartTestTemplate

- Will allow validation of "value" field on StockItemTestResult

* Run validation against StockItemTestResult

* Expose 'choices' to serializer

* Update unit test

* Add unit test for test result validation

* Add 'choices' field for CUI forms

* Add "choices" field to PUI form

* Add 'choices' column to PartTestTemplateTable

* memoize stockitemtestresult fields

- Adjust field type of "value" field based on template choices

* Bump API version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Relates to the API enhancement This is an suggested enhancement or new feature stock Related to Stock models
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant