-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] Add permissions to groups #7621
[PUI] Add permissions to groups #7621
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
@SchrodingersGat what is the current way to expose endpoint filters to the schema generator? |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7621 +/- ##
==========================================
- Coverage 83.70% 83.65% -0.05%
==========================================
Files 1105 1106 +1
Lines 48869 48920 +51
Branches 1576 1578 +2
==========================================
+ Hits 40906 40925 +19
- Misses 7548 7585 +37
+ Partials 415 410 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sorry, what do you mean by "endpoint filters"? |
@SchrodingersGat path parameters like |
@matmair mostly they don't. There are a few "hidden" constructs in the API - which I am slowly working through and fixing. But, mostly the extra "detail" filters are handled manually and thus not exposed to the schema |
Ok, so I do not need to expose them? |
No, no need to. |
…add-permissions-to-pui
@SchrodingersGat @wolflu05 ready for review |
@SchrodingersGat I have fixed the CI tests by adjusting to the changed defaults and adding the missing permissions to the test classes |
@matmair nice work, this is a good addition to the new interface. |
This PR replaces the placeholder for group permissions with a row of accordions listing the permissions.
For this the PR:
Group
model to various integrated rendering methodsScreenshots