Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable MFA #7757

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Jul 29, 2024

This PR adds a installation level option to disable MFA entirely. MFA is kept enabled by default but can be turned off via config.yaml or environment variable.

Replaces #7747
See #7746

@matmair matmair added security Relates to a security issue setup Relates to the InvenTree setup / installation process labels Jul 29, 2024
@matmair matmair added this to the 0.16.0 milestone Jul 29, 2024
@matmair matmair self-assigned this Jul 29, 2024
Copy link

netlify bot commented Jul 29, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit 6cb02ca
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66a809400e4c3a00088ad923

@matmair
Copy link
Member Author

matmair commented Jul 29, 2024

@SchrodingersGat do we want to reflect the disabling of MFA in the UI? I see this as a very fringe use case - mostly for the demo site

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.52%. Comparing base (637a7fe) to head (6cb02ca).
Report is 326 commits behind head on master.

Files with missing lines Patch % Lines
src/backend/InvenTree/InvenTree/forms.py 50.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7757      +/-   ##
==========================================
- Coverage   83.52%   83.52%   -0.01%     
==========================================
  Files        1114     1114              
  Lines       49355    49364       +9     
  Branches     1571     1571              
==========================================
+ Hits        41225    41231       +6     
- Misses       7734     7737       +3     
  Partials      396      396              
Flag Coverage Δ
backend 85.35% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 930356f into inventree:master Jul 30, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the disable-mfa-ref branch July 30, 2024 10:56
@SchrodingersGat
Copy link
Member

Nice one @matmair thanks for implementing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
security Relates to a security issue setup Relates to the InvenTree setup / installation process
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants