Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Fix user detail save on PUI #7906

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Aug 18, 2024

This PR fixes editing first and last name of a user (by themself). For this, a small API change is needed.

@matmair matmair added bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface labels Aug 18, 2024
@matmair matmair added this to the 0.17.0 milestone Aug 18, 2024
@matmair matmair self-assigned this Aug 18, 2024
Copy link

netlify bot commented Aug 18, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit fbf3edf
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66c268223b1826000810f47c
😎 Deploy Preview https://deploy-preview-7906--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@matmair matmair marked this pull request as ready for review August 18, 2024 21:31
Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.49%. Comparing base (7178b95) to head (fbf3edf).
Report is 328 commits behind head on master.

Files with missing lines Patch % Lines
...ex/Settings/AccountSettings/AccountDetailPanel.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7906   +/-   ##
=======================================
  Coverage   83.48%   83.49%           
=======================================
  Files        1131     1131           
  Lines       50359    50361    +2     
  Branches     1740     1740           
=======================================
+ Hits        42042    42048    +6     
+ Misses       7869     7868    -1     
+ Partials      448      445    -3     
Flag Coverage Δ
backend 85.20% <100.00%> (-0.01%) ⬇️
pui 65.29% <0.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 8a0d22d into inventree:master Aug 18, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the fix-user-detail-save branch August 18, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants