Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Add codecov bundler analyzer #8097

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 9, 2024

This PR adds support for codecovs bundler analyzer.
For that it introduces a vite plugin that analyzes the bundle at build time and uploads the results for historical analysis to codecov.

A PR comment is added with the analysis results (only running on changes to PUI were made in the PR).

@matmair matmair added CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface labels Sep 9, 2024
@matmair matmair added this to the 0.17.0 milestone Sep 9, 2024
@matmair matmair self-assigned this Sep 9, 2024
Copy link

netlify bot commented Sep 9, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 0cc0d7d
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66e09173ddb9f90008653fb8
😎 Deploy Preview https://deploy-preview-8097--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (30ab365) to head (0cc0d7d).
Report is 303 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8097      +/-   ##
==========================================
+ Coverage   83.75%   84.43%   +0.68%     
==========================================
  Files        1143     1144       +1     
  Lines       51084    51226     +142     
  Branches     1790     1815      +25     
==========================================
+ Hits        42787    43255     +468     
+ Misses       7836     7756      -80     
+ Partials      461      215     -246     
Flag Coverage Δ
pui 69.18% <ø> (+4.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member

LGTM @matmair - any further work here or good to go?

@matmair
Copy link
Member Author

matmair commented Sep 11, 2024

@SchrodingersGat ready to go

@SchrodingersGat SchrodingersGat merged commit a5ab4a3 into inventree:master Sep 13, 2024
43 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-add-bundler-analyzer branch September 13, 2024 23:30
@SchrodingersGat
Copy link
Member

Thanks @matmair

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI CI / unit testing ecosystem User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants