Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Refactor keeping modelinfo together #8104

Merged
merged 4 commits into from
Sep 10, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 10, 2024

Follow up to #8093. This PR reverts the organisation of model information to the old model with 1 important change: labels and lables_multiple are now functions to enable live translations.

@matmair matmair added refactor User Interface Related to the frontend / User Interface labels Sep 10, 2024
@matmair matmair added this to the 0.17.0 milestone Sep 10, 2024
@matmair matmair self-assigned this Sep 10, 2024
@matmair matmair changed the title [PUI ]Keeping modelinfo together [PUI] Refactor keeping modelinfo together Sep 10, 2024
Copy link

netlify bot commented Sep 10, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 3c0377b
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66dfedf99c9ea60008b8ef12
😎 Deploy Preview https://deploy-preview-8104--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 19.35484% with 50 lines in your changes missing coverage. Please review.

Project coverage is 83.74%. Comparing base (a8a3266) to head (3c0377b).
Report is 295 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/render/ModelType.tsx 19.35% 50 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8104      +/-   ##
==========================================
+ Coverage   83.67%   83.74%   +0.06%     
==========================================
  Files        1143     1143              
  Lines       51084    51080       -4     
  Branches     1790     1788       -2     
==========================================
+ Hits        42747    42778      +31     
+ Misses       7889     7846      -43     
- Partials      448      456       +8     
Flag Coverage Δ
pui 64.75% <19.35%> (+0.39%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 9219d83 into inventree:master Sep 10, 2024
28 checks passed
@SchrodingersGat SchrodingersGat deleted the fix-modelinfo branch September 10, 2024 23:48
@SchrodingersGat
Copy link
Member

Nice, this is much cleaner :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants