Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image upload for company page #8120

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix image upload for company page #8120

merged 1 commit into from
Sep 13, 2024

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User interface backport Apply this label to a PR to enable auto-backport action Platform UI Related to the React based User Interface backport-to-0.16.x labels Sep 12, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Sep 12, 2024
@SchrodingersGat SchrodingersGat mentioned this pull request Sep 12, 2024
Closed
6 tasks
@netlify Netlify
Copy link

netlify bot commented Sep 12, 2024 •
edited
Loading

✅ Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 0baec90
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66e36facc6e95d00085ad02c
😎 Deploy Preview https://deploy-preview-8120--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 98 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov Codecov
Copy link

codecov bot commented Sep 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.50%. Comparing base (83d2624) to head (0baec90).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8120      +/-   ##
==========================================
+ Coverage   84.42%   84.50%   +0.08%     
==========================================
  Files        1144     1144              
  Lines       51190    51190              
  Branches     1792     1792              
==========================================
+ Hits        43217    43258      +41     
+ Misses       7757     7716      -41     
  Partials      216      216
Flag Coverage Δ
pui 69.05% <ø> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

matmair
matmair approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@matmair matmair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; was/is this covered by functional tests?

@SchrodingersGat SchrodingersGat merged commit d4e67c0 into inventree:master Sep 13, 2024
31 checks passed
@SchrodingersGat SchrodingersGat deleted the company-image-fix branch September 13, 2024 01:34
github-actions bot pushed a commit that referenced this pull request Sep 13, 2024
@SchrodingersGat
Fix image upload for company page (#8120)
1689993 
- Fixes #8111

(cherry picked from commit d4e67c0)
@github-actions GitHub Actions
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 0.16.x

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request Sep 13, 2024
Merged
SchrodingersGat added a commit that referenced this pull request Sep 13, 2024
@github-actions @SchrodingersGat
Fix image upload for company page (#8120) (#8123)
4e8c59c 
- Fixes #8111

(cherry picked from commit d4e67c0)

Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matmair matmair matmair approved these changes

Assignees
No one assigned
Labels
backport Apply this label to a PR to enable auto-backport action backport-to-0.16.x bug Identifies a bug which needs to be addressed Platform UI Related to the React based User Interface user interface User interface
Projects
None yet
Milestone
0.17.0
Development

Successfully merging this pull request may close these issues.

Error when uploading images to Company/Part/etc
2 participants
@SchrodingersGat @matmair