Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More style fixes #8140

Merged
merged 3 commits into from
Sep 17, 2024
Merged

More style fixes #8140

merged 3 commits into from
Sep 17, 2024

Conversation

matmair
Copy link
Member

@matmair matmair commented Sep 17, 2024

Follow up to #8133 - even more style fixes. Maybe we should turn on alerts again.

@matmair matmair added this to the 0.17.0 milestone Sep 17, 2024
@matmair matmair self-assigned this Sep 17, 2024
Copy link

netlify bot commented Sep 17, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 6681d8c
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66e9fb39d02aeb00082d99bc
😎 Deploy Preview https://deploy-preview-8140--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 79.34783% with 19 lines in your changes missing coverage. Please review.

Project coverage is 84.37%. Comparing base (9aab352) to head (6681d8c).
Report is 299 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/forms/ApiForm.tsx 40.00% 3 Missing ⚠️
...c/frontend/src/components/settings/SettingList.tsx 50.00% 3 Missing ⚠️
.../frontend/src/components/forms/InstanceOptions.tsx 0.00% 2 Missing ⚠️
...c/frontend/src/tables/part/ParametricPartTable.tsx 0.00% 2 Missing ⚠️
...c/frontend/src/components/details/DetailsImage.tsx 0.00% 1 Missing ⚠️
.../frontend/src/components/forms/HostOptionsForm.tsx 0.00% 1 Missing ⚠️
.../frontend/src/components/forms/StandaloneField.tsx 0.00% 1 Missing ⚠️
src/frontend/src/components/nav/DetailDrawer.tsx 50.00% 1 Missing ⚠️
src/frontend/src/forms/StockForms.tsx 0.00% 1 Missing ⚠️
...Index/Settings/AccountSettings/SecurityContent.tsx 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8140      +/-   ##
==========================================
+ Coverage   84.33%   84.37%   +0.04%     
==========================================
  Files        1149     1149              
  Lines       51455    51464       +9     
  Branches     1807     1807              
==========================================
+ Hits        43394    43423      +29     
+ Misses       7849     7830      -19     
+ Partials      212      211       -1     
Flag Coverage Δ
pui 68.19% <79.34%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit dc58198 into inventree:master Sep 17, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the more-style-fixes branch September 17, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants