Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Fix for plugin table #8189

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

SchrodingersGat
Copy link
Member

  • useServerApiState() was constantly refreshing
  • This was causing infinite update cycles

- useServerApiState() was constantly refreshing
- This was causing infinite update cycles
@SchrodingersGat SchrodingersGat added bug Identifies a bug which needs to be addressed user interface User Interface Related to the frontend / User Interface labels Sep 26, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Sep 26, 2024
Copy link

netlify bot commented Sep 26, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit a1fa8e9
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/66f4f8684d49bf00084fb630
😎 Deploy Preview https://deploy-preview-8189--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🔴 down 1 from production)
Accessibility: 86 (no change from production)
Best Practices: 92 (no change from production)
SEO: 70 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 84.15%. Comparing base (752b331) to head (a1fa8e9).
Report is 312 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/tables/plugin/PluginListTable.tsx 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8189      +/-   ##
==========================================
+ Coverage   84.13%   84.15%   +0.01%     
==========================================
  Files        1154     1154              
  Lines       51898    51887      -11     
  Branches     1860     1856       -4     
==========================================
+ Hits        43666    43667       +1     
+ Misses       8022     8007      -15     
- Partials      210      213       +3     
Flag Coverage Δ
pui 67.44% <0.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 4d48a10 into inventree:master Sep 26, 2024
29 checks passed
@SchrodingersGat SchrodingersGat deleted the plugin-fix branch September 26, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant