-
-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Shipment Reports #8194
Shipment Reports #8194
Conversation
✅ Deploy Preview for inventree-web-pui-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you for the PR. Let's see if all style checks pass - this is good to merge from my POV
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8194 +/- ##
==========================================
- Coverage 83.87% 83.78% -0.10%
==========================================
Files 1161 1161
Lines 52188 52190 +2
Branches 1892 1892
==========================================
- Hits 43772 43725 -47
- Misses 7943 8006 +63
+ Partials 473 459 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@fuzeman nice addition, thanks!! |
Thanks. I've been using InvenTree almost daily for build orders and stock management over the last 3 years and finally had the push to make my first contribution. Hopefully more PR's to come when time allows. |
Contributions are always welcome 🤗 And it is wonderful to hear such feedback |
Just noticed that the "Attach to Model on Print" functionality probably won't work as I'll take a look, but let me know if you have any thoughts. |
After taking a closer look at how attachments are implemented, the simplest option would probably be a custom |
@fuzeman I think your suggested approach is reasonable, but could we have a situation where a user could manually create an attachment against a |
@SchrodingersGat Thanks. See PR #8231. |
This pull request implements sales order shipment reports which will enable greater flexibility for the generation of packing lists.
I found some previous discussions in #5232 and #62 around packing lists, but the solutions discussed appeared to be only suitable for generating a packing list of an entire sales order. I usually have long-running sales orders with weekly shipments requiring individual packing slips and it will be great to have this integrated inside InvenTree.
Sample Report (included in pull request):