Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Notes Editor UX #8265

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

Improve buttons layout for markdown notes editor

- Mucks around with editor focus
- Need to revisit this
@SchrodingersGat SchrodingersGat added user interface User Interface Related to the frontend / User Interface labels Oct 9, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Oct 9, 2024
Copy link

netlify bot commented Oct 9, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit be1e921
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67079bf96362bc0008a78125

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 84.28%. Comparing base (914f59c) to head (be1e921).
Report is 312 commits behind head on master.

Files with missing lines Patch % Lines
...rc/frontend/src/components/editors/NotesEditor.tsx 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8265      +/-   ##
==========================================
+ Coverage   84.22%   84.28%   +0.05%     
==========================================
  Files        1162     1162              
  Lines       52519    52502      -17     
  Branches     1894     1893       -1     
==========================================
+ Hits        44236    44252      +16     
+ Misses       7813     7767      -46     
- Partials      470      483      +13     
Flag Coverage Δ
pui 66.25% <66.66%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat
Copy link
Member Author

Waiting for #8269 to be merged

@SchrodingersGat SchrodingersGat merged commit 35969b1 into inventree:master Oct 10, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the notes-save branch October 10, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants