Notifications fix #8360
Merged
Notifications fix #8360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
SchrodingersGat
commented
Oct 25, 2024
SchrodingersGat
commented
- Fixes bug which prevented "low stock" notifications from being sent
- Notification methods were not collected properly in the background worker
- Closes Subscribed part notification bug #7448
- Allow collection for background worker too
SchrodingersGat
added
bug
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8360 +/- ##
==========================================
- Coverage 84.42% 84.42% -0.01%
==========================================
Files 1166 1166
Lines 53028 53037 +9
Branches 1946 1946
==========================================
+ Hits 44771 44778 +7
- Misses 7761 7763 +2
Partials 496 496
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- Cache methods more intelligently - Re-collect if null
github-actions bot
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Fix for app loading - Allow collection for background worker too * Improved logging * Refactor MethodStorageClass - Cache methods more intelligently - Re-collect if null (cherry picked from commit 331692b)
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
SchrodingersGat
added a commit
that referenced
this pull request
Oct 25, 2024
* Fix for app loading - Allow collection for background worker too * Improved logging * Refactor MethodStorageClass - Cache methods more intelligently - Re-collect if null (cherry picked from commit 331692b) Co-authored-by: Oliver <oliver.henry.walters@gmail.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.