Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] Page titles #8467

Merged
merged 10 commits into from
Nov 12, 2024
Merged

Conversation

SchrodingersGat
Copy link
Member

@SchrodingersGat SchrodingersGat added user interface User Interface Related to the frontend / User Interface labels Nov 12, 2024
@SchrodingersGat SchrodingersGat added this to the 0.17.0 milestone Nov 12, 2024
Copy link

netlify bot commented Nov 12, 2024

Deploy Preview for inventree-web-pui-preview ready!

Name Link
🔨 Latest commit 295b5e3
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/67334e94f69c5f00083052f5
😎 Deploy Preview https://deploy-preview-8467--inventree-web-pui-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 86 (no change from production)
Best Practices: 100 (no change from production)
SEO: 78 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 84.26%. Comparing base (113b9e9) to head (295b5e3).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/frontend/src/components/nav/PageTitle.tsx 76.19% 4 Missing and 1 partial ⚠️
...frontend/src/pages/Index/Settings/UserSettings.tsx 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8467      +/-   ##
==========================================
- Coverage   84.36%   84.26%   -0.11%     
==========================================
  Files        1175     1176       +1     
  Lines       53666    53678      +12     
  Branches     2012     2016       +4     
==========================================
- Hits        45277    45231      -46     
- Misses       7874     7942      +68     
+ Partials      515      505      -10     
Flag Coverage Δ
pui 68.14% <80.00%> (-0.57%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SchrodingersGat SchrodingersGat merged commit 7b50f3b into inventree:master Nov 12, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the page-title branch November 12, 2024 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
User Interface Related to the frontend / User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Improve page titles for PUI
2 participants