Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PUI] SSO improvments #8527

Merged
merged 5 commits into from
Nov 24, 2024
Merged

Conversation

matmair
Copy link
Member

@matmair matmair commented Nov 19, 2024

This addresses various ux issues/bugs in the SSO implementation in PUI.

Fixes #7972

@matmair matmair added bug Identifies a bug which needs to be addressed security Relates to a security issue labels Nov 19, 2024
@matmair matmair added this to the 0.17.0 milestone Nov 19, 2024
@matmair matmair self-assigned this Nov 19, 2024
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for inventree-web-pui-preview canceled.

Name Link
🔨 Latest commit c54b647
🔍 Latest deploy log https://app.netlify.com/sites/inventree-web-pui-preview/deploys/6743432a7eb1130008b01880

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 20 lines in your changes missing coverage. Please review.

Project coverage is 83.12%. Comparing base (13440a6) to head (c54b647).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...rc/backend/InvenTree/InvenTree/social_auth_urls.py 28.00% 18 Missing ⚠️
src/frontend/src/components/buttons/SSOButton.tsx 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8527      +/-   ##
==========================================
- Coverage   84.61%   83.12%   -1.49%     
==========================================
  Files        1178     1178              
  Lines       53584    55135    +1551     
  Branches     2026     2027       +1     
==========================================
+ Hits        45340    45833     +493     
- Misses       7722     8790    +1068     
+ Partials      522      512      -10     
Flag Coverage Δ
backend 85.94% <35.71%> (-0.02%) ⬇️
pui 68.68% <0.00%> (-0.59%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@matmair
Copy link
Member Author

matmair commented Nov 20, 2024

@SchrodingersGat @wolflu05 this now works but is not very beautiful; is this changeset ok or should we (I) search for a different solution?

@matmair matmair marked this pull request as ready for review November 20, 2024 18:43
@matmair matmair mentioned this pull request Nov 20, 2024
6 tasks
@SchrodingersGat
Copy link
Member

SchrodingersGat commented Nov 20, 2024

@matmair can you please provide a simple overview of what the issue was that you are fixing here? I understand the frontend fix (hiding the buttons if invalid) but what about the backend changes?

@SchrodingersGat
Copy link
Member

@matmair any comments on the changes in social_auth_urls.py?

@matmair
Copy link
Member Author

matmair commented Nov 24, 2024

The current arrangement of URL definitions leads to errors in the discovery of the OIDC endpoints, the new one fixes that.

@SchrodingersGat SchrodingersGat merged commit 66a769e into inventree:master Nov 24, 2024
26 checks passed
@SchrodingersGat SchrodingersGat deleted the pui-sso-improvments branch November 24, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Identifies a bug which needs to be addressed security Relates to a security issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PUI login issue with OpenIDConnect
2 participants