-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PUI] SSO improvments #8527
[PUI] SSO improvments #8527
Conversation
✅ Deploy Preview for inventree-web-pui-preview canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8527 +/- ##
==========================================
- Coverage 84.61% 83.12% -1.49%
==========================================
Files 1178 1178
Lines 53584 55135 +1551
Branches 2026 2027 +1
==========================================
+ Hits 45340 45833 +493
- Misses 7722 8790 +1068
+ Partials 522 512 -10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
@SchrodingersGat @wolflu05 this now works but is not very beautiful; is this changeset ok or should we (I) search for a different solution? |
@matmair can you please provide a simple overview of what the issue was that you are fixing here? I understand the frontend fix (hiding the buttons if invalid) but what about the backend changes? |
@matmair any comments on the changes in |
The current arrangement of URL definitions leads to errors in the discovery of the OIDC endpoints, the new one fixes that. |
This addresses various ux issues/bugs in the SSO implementation in PUI.
Fixes #7972