Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NTLM auth API missing logs #8448

Open
wants to merge 4 commits into
base: maintenance/14.0
Choose a base branch
from

Conversation

stgmsa
Copy link
Contributor

@stgmsa stgmsa commented Dec 19, 2024

Description

Fix missing NTLM auth API logs
added several common error cases for easier troubleshooting.

Impacts

  • changed logging handler, from directly using print to built-in logging component.
  • added several hints when specific NTError occurred.

Issue

fixes #8414

Delete branch after merge

YES

Checklist

(REQUIRED) - [yes, no or n/a]

  • [no] Document the feature
  • [no] Add OpenAPI specification
  • [no] Add unit tests
  • [no] Add acceptance tests (TestLink)

Enhancements

added more detailed logs of ntlm-auth-api
added several common NTErrors

Bug Fixes

adds logging module
modify default app logging format
Comment on lines +13 to +21
# file_handler = logging.FileHandler("app.log")
# file_handler.setLevel(default_logging_level)

formatter = logging.Formatter('%(asctime)s - %(levelname)s - %(message)s', datefmt="%Y-%m-%d %H:%M:%S")
console_handler.setFormatter(formatter)
# file_handler.setFormatter(formatter)

logger.addHandler(console_handler)
# logger.addHandler(file_handler)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants