fix(globe_cli): Bad state no element error on deployment fixed #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lesnitsky
suggested changes
Dec 12, 2023
There was a problem hiding this comment.
there is a chance we get this error again, because firstWhere is still being used. It's worth improving Deployment.fromJson logic, so that the error is more descriptive.
…d DeploymentState
lesnitsky
approved these changes
Dec 13, 2023
Salakar
changed the title
kaziwaseef
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cli was showing the following error output on the deploy command in the latest version (0.0.1+1)
This PR fixes the bug
Description
There was a missing state
deployingthat was added to theDeploymentStateenum and log handling was also added.Type of Change
feat-- New feature (non-breaking change which adds functionality)fix-- Bug fix (non-breaking change which fixes an issue)!-- Breaking change (fix or feature that would cause existing functionality to change)refactor-- Code refactorci-- Build configuration changedocs-- Documentationchore-- Chore