Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for melos bs --skip-linking #684

Merged
merged 6 commits into from
Mar 29, 2024

Conversation

xsahil03x
Copy link
Contributor

@xsahil03x xsahil03x commented Mar 29, 2024

Description

Fixes: #682
Adds a new flag --skip-linking to the melos bs.

Logs

  • with --skip-linking enabled
melos bootstrap
  └> /Users/sahilkumar/StudioProjects/melos

Updating common dependencies in workspace packages...
  ✓ melos
    └> Updated environment
  ✓ melos_workspace
    └> Updated environment
  ✓ conventional_commit
    └> Updated environment
  > SUCCESS

Generating IntelliJ IDE files...
  > SUCCESS

 -> 3 packages bootstrapped
  • with --skip-linking disabled
melos bootstrap
  └> /Users/sahilkumar/StudioProjects/melos

Updating common dependencies in workspace packages...
  ✓ conventional_commit
    └> Updated environment
  ✓ melos
    └> Updated environment
  ✓ melos_workspace
    └> Updated environment
  > SUCCESS

Running "dart pub get" in workspace packages...
  ✓ conventional_commit
    └> packages/conventional_commit
  ✓ melos_workspace
    └> .
  ✓ melos
    └> packages/melos
  > SUCCESS

Generating IntelliJ IDE files...
  > SUCCESS

 -> 3 packages bootstrapped

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
@xsahil03x xsahil03x marked this pull request as ready for review March 29, 2024 10:13
Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
Copy link
Collaborator

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good to me!
Just two small nits.

Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
Signed-off-by: Sahil Kumar <sahil.kumar@tide.co>
@xsahil03x xsahil03x requested a review from spydon March 29, 2024 10:39
@spydon spydon merged commit 699fedc into invertase:main Mar 29, 2024
12 checks passed
@xsahil03x xsahil03x deleted the feat/bs-skip-linking branch March 29, 2024 11:19
@xsahil03x
Copy link
Contributor Author

Hey @spydon , can we do a new release today with all the new features available in main? Thanks

@spydon
Copy link
Collaborator

spydon commented Apr 1, 2024

Hey @spydon , can we do a new release today with all the new features available in main? Thanks

Hey,
Did you see my other comment where you pinged me for a release? You can easily use main directly while waiting for a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request: extract setSharedDependencies as a separate melos command
2 participants