Skip to content

Commit

Permalink
fix(android): generate version for ReactNativeFirebaseAppRegistrar.ja…
Browse files Browse the repository at this point in the history
…va (#3766)

* build(android): script for version

* chore(android): rm ReactNativeFirebaseAppRegistrar

* build(android): create new version class

* chore(android): update script file name

* chore(app, android): formatting

Co-authored-by: Mike Diarmid <mike.diarmid@gmail.com>
[publish]
  • Loading branch information
russellwheatley committed Jun 10, 2020
1 parent 88f8dc0 commit 1324985
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 10 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -549,8 +549,9 @@ tests/ios/resetXcode.sh
google-services.json
GoogleService-Info.plist

# generated file
# generated files
RNFBVersion.m
ReactNativeFirebaseVersion.java

appPlaygrounds/
app.playground.js
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,15 @@
import java.util.Collections;
import java.util.List;

import io.invertase.firebase.BuildConfig;

@Keep
public class ReactNativeFirebaseAppRegistrar implements ComponentRegistrar {
@Override
public List<Component<?>> getComponents() {
return Collections.singletonList(
LibraryVersionComponent.create(
"react-native-firebase",
BuildConfig.VERSION_NAME
)
);
return Collections
.singletonList(
LibraryVersionComponent.create(
"react-native-firebase",
ReactNativeFirebaseVersion.VERSION
));
}
}
3 changes: 2 additions & 1 deletion packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@
"main": "lib/index.js",
"types": "lib/index.d.ts",
"scripts": {
"build": "genversion --semi lib/version.js && node ./scripts/genversion-ios",
"build": "genversion --semi lib/version.js && npm run build:version",
"build:version": "node ./scripts/genversion-ios && node ./scripts/genversion-android",
"build:clean": "rimraf android/build && rimraf ios/build",
"prepare": "npm run build"
},
Expand Down
36 changes: 36 additions & 0 deletions packages/app/scripts/genversion-android.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
const fs = require('fs');
const path = require('path');

const version = require('../lib/version');
const outputPath = path.resolve(
__dirname,
'..',
'android',
'src/reactnative/java/io/invertase/firebase/app',
'ReactNativeFirebaseVersion.java',
);
const template = `
package io.invertase.firebase.app;
/*
* Copyright (c) 2016-present Invertase Limited & Contributors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this library except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*/
// generated file - do not modify or commit
public class ReactNativeFirebaseVersion {
public static String VERSION = "version_number";
}
`;

fs.writeFileSync(outputPath, template.replace('version_number', `${version}`), 'utf8');

0 comments on commit 1324985

Please sign in to comment.