Skip to content

Commit

Permalink
fix(app, ios-plist): make sure Info.plist exists before processing
Browse files Browse the repository at this point in the history
Previously there was no dependency stated on Info.plist, so occasionally we would "lose the race"
and attempt to interpolate values prior to it existing

Since ads requires the Info.plist admob ids in the Info.plist, this resulted in crashes on startup occasionally
for users of the admob module

Fixes #5152
  • Loading branch information
mikehardy committed Apr 11, 2021
1 parent 1f315c1 commit 245149c
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/app/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ module.exports = {
name: '[RNFB] Core Configuration',
path: './ios_config.sh',
execution_position: 'after_compile',
input_files: ['$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)'],
},
],
},
Expand Down

1 comment on commit 245149c

@vercel
Copy link

@vercel vercel bot commented on 245149c Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.