Skip to content

Commit

Permalink
fix(app, ios-plist): make sure Info.plist exists before processing
Browse files Browse the repository at this point in the history
Previously there was no dependency stated on Info.plist, so occasionally we would "lose the race"
and attempt to interpolate values prior to it existing

Since ads requires the Info.plist admob ids in the Info.plist, this resulted in crashes on startup occasionally
for users of the admob module

Fixes #5152
  • Loading branch information
mikehardy authored Apr 10, 2021
1 parent 391a9dc commit 641b2a7
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions packages/app/react-native.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ module.exports = {
name: '[RNFB] Core Configuration',
path: './ios_config.sh',
execution_position: 'after_compile',
input_files: [
'$(SRCROOT)/$(BUILT_PRODUCTS_DIR)/$(INFOPLIST_PATH)',
],
},
],
},
Expand Down

0 comments on commit 641b2a7

Please sign in to comment.