fix(database, types): harmonize database.on() w/firebase-js-sdk

This builds on the work both upstream and in this repo of @SCasarotto from #4550
invertase · Apr 9, 2021 · 6aea33f · 6aea33f · vercel · Apr 9, 2021
1 parent d2838ff
commit 6aea33f
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/packages/database/lib/index.d.ts b/packages/database/lib/index.d.ts
@@ -658,11 +658,11 @@ export namespace FirebaseDatabaseTypes {
      *
      */
     on(
-      eventType?: EventType,
-      callback?: (data: DataSnapshot, previousChildKey?: string) => void,
+      eventType: EventType,
+      callback: (data: DataSnapshot, previousChildKey?: string | null) => void,
       cancelCallbackOrContext?: ((a: Error) => void) | Record<string, any> | null,
       context?: Record<string, any> | null,
-    ): (a: DataSnapshot, b?: string | null) => void;
+    ): (a: DataSnapshot | null, b?: string | null) => void;
 
     /**
      * Listens for exactly one event of the specified event type, and then stops listening.