Skip to content

Commit

Permalink
fix(messaging, android): avoid using rn61+ symbol
Browse files Browse the repository at this point in the history
this should be the inline equivalent of the rn61 symbol I added
in #5236 - accidentally breaking react-native 0.60 compatibility
  • Loading branch information
mikehardy committed May 12, 2021
1 parent 3b48240 commit 7e6f8d9
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.bridge.WritableNativeMap;
import com.google.android.gms.tasks.Tasks;
import com.google.firebase.iid.FirebaseInstanceId;
import com.google.firebase.messaging.FirebaseMessaging;
Expand Down Expand Up @@ -231,7 +232,9 @@ public void onNewIntent(Intent intent) {

if (remoteMessageMap != null) {
// WritableNativeMap not be consumed twice. But it is resolved in future and in event below. Make a copy - issue #5231
initialNotification = remoteMessageMap.copy();
WritableNativeMap newInitialNotification = new WritableNativeMap();
newInitialNotification.merge(remoteMessageMap);
initialNotification = newInitialNotification;
ReactNativeFirebaseMessagingReceiver.notifications.remove(messageId);

ReactNativeFirebaseEventEmitter emitter = ReactNativeFirebaseEventEmitter.getSharedInstance();
Expand Down
2 changes: 1 addition & 1 deletion packages/messaging/e2e/messaging.e2e.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
*/

describe('messaging()', function () {
describe.only('messaging()', function () {
describe('namespace', function () {
it('accessible from firebase.app()', function () {
const app = firebase.app();
Expand Down

0 comments on commit 7e6f8d9

Please sign in to comment.