Skip to content

Commit

Permalink
fix(remote-config): error calling getValue() before fetch (#4068)
Browse files Browse the repository at this point in the history
* fix(remote-config/app): error while calling remoteConfig().getValue() before fetch success.

* fix(remote-config): error while calling remoteConfig().getValue() before fetch success.

Co-authored-by: Mike Hardy <github@mikehardy.net>
  • Loading branch information
imwexpex and mikehardy authored Aug 15, 2020
1 parent 67ca4d0 commit 8619d72
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/remote-config/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ class FirebaseConfigModule extends FirebaseModule {
throw new Error("firebase.remoteConfig().getValue(): 'key' must be a string value.");
}

if (!hasOwnProperty(this._values, key)) {
if (typeof this._values === 'undefined' || !hasOwnProperty(this._values, key)) {
return new Value({
value: '',
source: 'static',
Expand Down

0 comments on commit 8619d72

Please sign in to comment.