feat: add GeoPoint toJSON() method

invertase · Jul 30, 2022 · b062e74 · b062e74 · vercel · Jul 30, 2022
1 parent 8fb859f
commit b062e74
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 0 deletions.
diff --git a/packages/firestore/e2e/GeoPoint.e2e.js b/packages/firestore/e2e/GeoPoint.e2e.js
@@ -106,6 +106,17 @@ describe('firestore.GeoPoint', function () {
       equal.should.equal(true);
     });
   });
+
+  describe('toJSON()', function () {
+    it('returns a json representation of the GeoPoint', function () {
+      const geo = new firebase.firestore.GeoPoint(100, 200);
+      geo.toJSON().should.deepEqual({
+        latitude: 100,
+        longitude: 200,
+      });
+    });
+  });
+
   it('sets & returns correctly', async function () {
     const ref = firebase.firestore().doc(`${COLLECTION}/geopoint`);
     await ref.set({

diff --git a/packages/firestore/lib/FirestoreGeoPoint.js b/packages/firestore/lib/FirestoreGeoPoint.js
@@ -66,4 +66,11 @@ export default class FirestoreGeoPoint {
 
     return this._latitude === other._latitude && this._longitude === other._longitude;
   }
+
+  toJSON() {
+    return {
+      latitude: this._latitude,
+      longitude: this._longitude,
+    };
+  }
 }
diff --git a/packages/firestore/lib/index.d.ts b/packages/firestore/lib/index.d.ts
@@ -808,6 +808,11 @@ export namespace FirebaseFirestoreTypes {
      * @param other The `GeoPoint` to compare against.
      */
     isEqual(other: GeoPoint): boolean;
+
+    /**
+     * Returns a JSON-serializable representation of this GeoPoint.
+     */
+    toJSON(): { latitude: number; longitude: number };
   }
 
   /**