Skip to content

Commit

Permalink
[v5] Remove recursive header search from ios podspec
Browse files Browse the repository at this point in the history
I believe following commit introduces an issue fro cocoapods users (of whoom there will be many now that react-native uses cocoapods) b85153d#diff-1b2b06e7c58d8929c91f917ce51a7454R28

The gist of it, that it introduces back this issue firebase/firebase-ios-sdk#1916
It is due to some header include in gRPC-C++ library that recursive header search will try to include, but won't find, hence causing build error.

cc @MoOx as he authored original PR, I am not sure if removing this will cause any issues, so wanted to discuss it with you.
  • Loading branch information
iljadaderko authored Jul 6, 2019
1 parent 447cf37 commit be5363b
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ios/RNFirebase.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,4 @@ Pod::Spec.new do |s|
end
# allow this package to be used with use_frameworks!
s.static_framework = true
# fix recursive header flag being skipped by cocoapods when using this as a framework
s.xcconfig = {
'HEADER_SEARCH_PATHS' => '${PODS_ROOT}/Headers/Public/**'
}
end

0 comments on commit be5363b

Please sign in to comment.