Skip to content

Commit

Permalink
feat(app): rename v9 to modular
Browse files Browse the repository at this point in the history
  • Loading branch information
Lyokone committed Nov 23, 2022
1 parent d6214df commit cb8415c
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
*
*/

describe('v9', function () {
describe('modular', function () {
describe('firebase v8 compatibility', function () {
it('it should allow read the default app from native', function () {
// app is created in tests app before all hook
Expand Down
2 changes: 1 addition & 1 deletion packages/app/lib/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { getFirebaseRoot } from './internal/registry/namespace';

export const firebase = getFirebaseRoot();
export * from './modular/app';
export { default as utils } from './utils';
export * from './v9/app';

export default firebase;
10 changes: 8 additions & 2 deletions packages/app/lib/v9/app.js → packages/app/lib/modular/app.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,19 @@
/* eslint-disable @typescript-eslint/no-unused-vars */
import { deleteApp as deleteAppV8, getApp, getApps, initializeApp, setLogLevel } from '../internal';
import {
deleteApp as deleteAppCompat,
getApp,
getApps,
initializeApp,
setLogLevel,
} from '../internal';

/**
* Renders this app unusable and frees the resources of all associated services.
* @param app - FirebaseApp - The app to delete.
* @returns
*/
export function deleteApp(app) {
return deleteAppV8(app.name, app._nativeInitialized);
return deleteAppCompat(app.name, app._nativeInitialized);
}

/**
Expand Down

0 comments on commit cb8415c

Please sign in to comment.