Skip to content

Commit

Permalink
feat(sdks): firebase-ios-sdk 8.0.0 / firebase-android-sdk 28.0.1
Browse files Browse the repository at this point in the history
includes bump to android gradle plugin 4.2.1 and associated lint fix
includes bumps to all of the google / firebase gradle plugins
  • Loading branch information
mikehardy committed May 15, 2021
1 parent 32e16bd commit d97587b
Show file tree
Hide file tree
Showing 9 changed files with 260 additions and 351 deletions.
2 changes: 1 addition & 1 deletion docs/crashlytics/android-setup.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ buildscript {
// ..
dependencies {
// ..
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.6.1'
}
// ..
}
Expand Down
6 changes: 3 additions & 3 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ First, add the `google-services` plugin as a dependency inside of your `/android
buildscript {
dependencies {
// ... other dependencies
classpath 'com.google.gms:google-services:4.3.4'
classpath 'com.google.gms:google-services:4.3.6'

This comment has been minimized.

Copy link
@marqroldan

marqroldan May 16, 2021

Hi, could we update this to 4.3.8 hehe (google/play-services-plugins#176 (comment))

Didn't open an issue as @/mikehardy might already be aware of it
I haven't tried out any other packages (just the 'app' module), at least it builds on my end

This comment has been minimized.

Copy link
@mikehardy

mikehardy May 16, 2021

Author Collaborator

😮 fixed the code in the test app but not the docs, and for this one the docs are more important!

// Add me --- /\
}
}
Expand Down Expand Up @@ -193,7 +193,7 @@ project.ext {
// Overriding Library SDK Versions
firebase: [
// Override Firebase SDK Version
bom : "26.6.0"
bom : "28.0.1"
],
],
])
Expand All @@ -208,7 +208,7 @@ Open your projects `/ios/Podfile` and add any of the globals shown below to the

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '7.7.0'
$FirebaseSDKVersion = '8.0.0'
```

Once changed, reinstall your projects pods via pod install and rebuild your project with `npx react-native run-ios`.
Expand Down
2 changes: 1 addition & 1 deletion docs/perf/usage/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ Add the plugin to your `/android/build.gradle` file as a dependency:
buildscript {
dependencies {
// ...
classpath 'com.google.firebase:perf-plugin:1.3.5'
classpath 'com.google.firebase:perf-plugin:1.4.0'
}
```

Expand Down
4 changes: 2 additions & 2 deletions packages/app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,14 +62,14 @@
},
"sdkVersions": {
"ios": {
"firebase": "7.11.0"
"firebase": "8.0.0"
},
"android": {
"minSdk": 16,
"targetSdk": 30,
"compileSdk": 30,
"buildTools": "30.0.2",
"firebase": "26.8.0",
"firebase": "28.0.1",
"playServicesAuth": "19.0.0"
}
}
Expand Down
8 changes: 4 additions & 4 deletions tests/android/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ buildscript {
mavenCentral()
}
dependencies {
classpath 'com.google.gms:google-services:4.3.5' // https://developers.google.com/android/guides/google-services-plugin
classpath 'com.android.tools.build:gradle:4.1.3'
classpath 'com.google.gms:google-services:4.3.8' // https://developers.google.com/android/guides/google-services-plugin
classpath 'com.android.tools.build:gradle:4.2.1'
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlinVersion"
classpath 'com.google.firebase:perf-plugin:1.3.5'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.5.2'
classpath 'com.google.firebase:perf-plugin:1.4.0'
classpath 'com.google.firebase:firebase-crashlytics-gradle:2.6.1'
}
}

Expand Down
2 changes: 1 addition & 1 deletion tests/android/lint.xml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
<issue id="StringFormatCount" severity="fatal" />
<issue id="StringFormatMatches" severity="fatal" />
<issue id="StringFormatInvalid" severity="fatal" />
<issue id="UnusedResources" severity="fatal" />
<issue id="UnusedResources" severity="ignore" />
<issue id="ViewConstructor" severity="fatal" />
<issue id="ViewHolder" severity="fatal" />
<issue id="ViewTag" severity="fatal" />
Expand Down
6 changes: 3 additions & 3 deletions tests/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@ require 'json'
# Settings to test various overrides if desired
appPackage = JSON.parse(File.read(File.join('..', '..', 'node_modules', '@react-native-firebase', 'app', 'package.json')))
$FirebaseSDKVersion = appPackage['sdkVersions']['ios']['firebase']
#$FirebaseSDKVersion = '7.7.0' # https://firebase.google.com/support/release-notes/ios
#$FirebaseSDKVersion = '8.0.0' # https://firebase.google.com/support/release-notes/ios
Pod::UI.puts "react-native-firebase/tests: Using Firebase SDK version '#{$FirebaseSDKVersion}'"
#$RNFirebaseAsStaticFramework = false # toggle this to true (and set 'use_frameworks!' below to test static frameworks)
# $RNFirebaseAsStaticFramework = true # toggle this to true (and set 'use_frameworks!' below to test static frameworks)

# Toggle this to true for the no-ad-tracking Analytics subspec. Useful at minimum for Kids category apps.
# See: https://firebase.google.com/support/release-notes/ios#analytics - requires firebase-ios-sdk 7.11.0+
Expand Down Expand Up @@ -35,7 +35,7 @@ target 'testing' do
# pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => $FirebaseSDKVersion

# If leveldb auto-inclusion fails and build fails with leveldb symbol conflicts, use this subspec:
pod 'FirebaseFirestore/WithoutLeveldb', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :commit => 'af5c7177c896d69d73acb173c265d7efe8886126'
pod 'FirebaseFirestore/WithoutLeveldb', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => $FirebaseSDKVersion

# Enables Flipper.
#
Expand Down
Loading

1 comment on commit d97587b

@vercel
Copy link

@vercel vercel bot commented on d97587b May 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.