Skip to content

Commit

Permalink
fix(firestore, types): make all Settings properties optional (#4965)
Browse files Browse the repository at this point in the history
This matches the optional typing of all Settings members in firebase-js-sdk
  • Loading branch information
kmsbernard authored Feb 28, 2021
1 parent bc893ab commit f501fff
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions packages/firestore/lib/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1394,7 +1394,7 @@ export namespace FirebaseFirestoreTypes {
/**
* Enables or disables local persistent storage.
*/
persistence: boolean;
persistence?: boolean;

/**
* An approximate cache size threshold for the on-disk data. If the cache grows beyond this size, Firestore will start
Expand All @@ -1403,7 +1403,7 @@ export namespace FirebaseFirestoreTypes {
*
* To disable garbage collection and set an unlimited cache size, use `firebase.firestore.CACHE_SIZE_UNLIMITED`.
*/
cacheSizeBytes: number;
cacheSizeBytes?: number;

/**
* The hostname to connect to.
Expand All @@ -1413,12 +1413,12 @@ export namespace FirebaseFirestoreTypes {
* If you want to use the emulator on a real android device, you will need to specify the actual host
* computer IP address.
*/
host: string;
host?: string;

/**
* Whether to use SSL when connecting.
*/
ssl: boolean;
ssl?: boolean;
}

/**
Expand Down

1 comment on commit f501fff

@vercel
Copy link

@vercel vercel bot commented on f501fff Feb 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.