Skip to content

Commit

Permalink
fix(ios, podspec): depend on React-Core instead of React (#4275)
Browse files Browse the repository at this point in the history
  • Loading branch information
mrousavy authored Sep 17, 2020
1 parent af9a71d commit fd1a2be
Show file tree
Hide file tree
Showing 19 changed files with 19 additions and 19 deletions.
2 changes: 1 addition & 1 deletion packages/admob/RNFBAdMob.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

# Other dependencies
Expand Down
2 changes: 1 addition & 1 deletion packages/analytics/RNFBAnalytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/app/RNFBApp.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Pod::Spec.new do |s|
s.source_files = "ios/**/*.{h,m}"

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'

if defined?($FirebaseSDKVersion)
Pod::UI.puts "#{s.name}: Using user specified Firebase SDK version '#{$FirebaseSDKVersion}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/RNFBAuth.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/crashlytics/RNFBCrashlytics.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/database/RNFBDatabase.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/dynamic-links/RNFBDynamicLinks.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/RNFBFirestore.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/functions/RNFBFunctions.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/iid/RNFBIid.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/in-app-messaging/RNFBInAppMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/messaging/RNFBMessaging.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/ml-natural-language/RNFBMLNaturalLanguage.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/ml-vision/RNFBMLVision.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/perf/RNFBPerf.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/remote-config/RNFBRemoteConfig.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/RNFBStorage.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Pod::Spec.new do |s|
s.source_files = 'ios/**/*.{h,m}'

# React Native dependencies
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'RNFBApp'

if defined?($FirebaseSDKVersion)
Expand Down
2 changes: 1 addition & 1 deletion scripts/_TEMPLATE_/RNFB_Template_.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Pod::Spec.new do |s|
s.social_media_url = 'http://twitter.com/invertaseio'
s.ios.deployment_target = "9.0"
s.source_files = 'ios/**/*.{h,m}'
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'Firebase/Core', '~> 5.20.2'
s.dependency 'RNFBApp'
s.static_framework = true
Expand Down
2 changes: 1 addition & 1 deletion scripts/_TEMPLATE_/ios/RNFB_Template_.podspec
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ Pod::Spec.new do |s|
s.social_media_url = 'http://twitter.com/invertaseio'
s.ios.deployment_target = "9.0"
s.source_files = 'RNFB_Template_/**/*.{h,m}'
s.dependency 'React'
s.dependency 'React-Core'
s.dependency 'Firebase/Core', '~> 5.20.2'
s.dependency 'RNFBApp'
s.static_framework = true
Expand Down

1 comment on commit fd1a2be

@vercel
Copy link

@vercel vercel bot commented on fd1a2be Sep 17, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.