-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apple warning UIWebView
#2535
Comments
Thanks for the report. Once the SDK version is released we'll get it tested and updated with a release. |
I'm not actually sure there is anything to do? Once it's released you just |
Just watch here since they cherry-picked to their 6.8.0 pending release. Once you see 6.8.0 install it https://firebase.google.com/support/release-notes/ios Also, this is an App Store warning, not a fail. They'll keep accepting these submissions for now. It's also affecting react-native-webview and react-native-device-info at minimum. |
I assume that the auth package needs to update this dependency
Re react-native-webview and react-native-device-info they both posted fixes |
Yeah on v6 we hard set the versions so that will need changing, v5 should be do-able via updating pods yourself. |
oh my - I haven't used v6 yet, the dependencies are coded into each subspec in the packages? they are not configurable in the main app podspec 😱 I am sure there are reasons for that design (like, making it so people don't have to think about adding dependencies...) but I'd hack up a pre script in my main app podspec to control the dependencies personally. sorta like this but moving versions or similar https://guides.cocoapods.org/syntax/podfile.html#pre_install - but I'm pretty touchy about being able to control my own versions |
also I can't imagine trying to track the ios sdk releases? e.g., firestore 6.7.1 is out and fixes a crash bug, if they release that sdk over the weekend is there some expectation you cut a release to match contemporaneously? or recommend patch-package? 🤔 - seems like a really tight coupling on something otherwise not in control |
Let me get back to you on the specifics. You can override the RNFB versions yourself though. I'll speak with @Salakar - probably one to document too. |
What is the current status of this warning? Our team is also running into this and points to FIRAuth. We are on v5.4.3 of RNFirebase. Would we simply update the Podfile |
They are fixing things on a very rapid basis - for instance a difference between Firebase iOS SDK release 6.8.0 and 6.8.1 was related to this even, https://firebase.google.com/support/release-notes/ios#version_681_-_september_10_2019 - just a few days ago. My best recommendation is to get completely current, even though I recognize this means ingesting some breaking changes - read the release notes carefully for react-native-firebase v5.5.0 (on your way to v5.5.6 and Pods 6.8.1) |
@quachsimon that was for you - I believe the original reporter was for react-native-firebase v6, which just had a "pod overrides" PR proposed by @Ehesp #2589 |
Thanks @mikehardy. Will look into updating to react-native-firebase v5.5.6. After that, I can just change my |
Oh dang - my documentation is in conflict. My goal with v5.x react-native-firebase maintenance is to allow use of the most up to date underlying SDKs, even if that means small breaking changes in RNFB. I'm personally on 6.8.1 and it's okay. I updated this table to just be '6.x' for the pods https://rnfirebase.io/docs/v5.x.x/getting-started#Supported-versions---React-Native-/-Firebase and I will update that doc to say that it is best to pin your version yes, but also periodically run So TLDR - 6.8.1 should be okay. If you are on react-native 0.60+ you must use the branch v5.x.x from git as there is a patch needed to make it work with AndroidX that we haven't released yet #2476 |
See if this is more clear: invertase/react-native-firebase-docs#217 - if you like it, you can say so on the PR and I'll merge. Open to any wording suggestions of course |
Amazing @mikehardy! Will update to the new version and update afterwards! |
@mikehardy Hi, i am on RN 0.59.10 using react-native-firebase ~5.5.5. I am getting the UIWebView warning from Apple as well. I realy cant transfer to RN 0.60 for production reasons. I am just worried if i will update to latest React Native Firebase i will be forced to switch to 0.60. Let me please know if there is some fix for this Apple warning and staying on RN 0.59.10. Thank you. |
no worries, I test it with rn59 and I believe it is still working - demonstration here: https://github.com/mikehardy/rnfbdemo/blob/master/make-demo-rn59.sh You will still have other work to do as well - I maintain react-native-device-info and it isn't fixed with regard to UIWebView until v3.x.x series, react-native-webview also only just recently. I believe both of those made the transition to AndroidX as well but...I also maintain jetifier, and using |
@mikehardy Thanks, yeah, i just need to stay on 0.59.10 since i am like 2 weeks from release. So just to clarify, i should update to 5.5.6 and update my pods right ? I am on these
I am not sure to what version i should update those to. I think you mentioned 6.8.1 is ok with 5.5.6 and RN 0.59.10 ? |
@LukePenkava yes, we are on 5.5.6 and have updated our pods to |
@quachsimon great, thank you |
yep - I've heard no bad reports on 0.59.10 + pods 6.8.1 (or 6.9.0 now) and 5.5.6 only for people that move from rn 0.59.10 to rn 0.60+ they may need an unreleased react-native-firebase patch that is committed to v5.x.x just not out as a 5.5.7 yet good luck with the release! |
@mikehardy thanks :) I can confirm that it works fine with 5.5.6 and 6.8.1. The issue with UIWebView when uploading to Appstore is still there tho. I searched through my RN project and it seems that all references to UIWebView are gone now ( before a lot of references to Firebase ), yet the Apple still gives the warning. It might be some other completely issue unrelated to React-Native-Firebase, but just wondering if you perhaps know what might be causing the issue. |
Hmm - I know of lots of sources of it. For instance I maintain react-native-device-info and that was a big rush fixing it, you need v3.x there. react-native-webview updated. You got the firebase ios sdk updated so that should be settled (unless maybe you need to deep clean your build system with a react-native-clean-project run where you say yes to "wipe iOS build"). If you look at the react-native-webview repo, there is an issue running there where a few people posted good troubleshooting tips to find other sources of UIWebView symbol references |
@mikehardy I will look into finding other sources of UIWebView. If the update should have solved the UIWebView issue for Firebase, then it must be something else. Thanks again. |
Hello 👋, to help manage issues we automatically close stale issues.
|
This is resolved I believe |
Installing Firebase (6.14.0) how to change firebaseauth to 6.8.1 ??? |
Installing Firebase (6.14.0) how to change it plzzz...help me @mikehardy |
this is my pod file platform :ios, '9.0' target 'avunja' do Comment the next line if you don't want to use dynamic frameworks#use_frameworks! Pods for avunjapod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga/Yoga.podspec' pod 'GoogleTagManager' target 'avunjaTests' do end post_install do |installer| rnfirebase = installer.pods_project.targets.find { |target| target.name == 'RNFirebase' } |
where should i change @mikehardy @LukePenkava |
is that okay @mikehardy Installing BoringSSL-GRPC (0.0.3) |
@stepupithub I get an email every time you comment. Once is good... Make it look sort of like this https://github.com/mikehardy/rnfbdemo/blob/master/PodfileRN59 except I don't keep up with the versions there, it's too old to spend the time. That said, if you are on react-native-firebase 5.5.6, I think Pods 6.13.0 would work just fine |
owe !!! i'm so sorry mike |
As a best practice always specify versions or your build is not reproducible |
based on invertase/react-native-firebase#2535 these versions should work with our version of RNFB
Issue
Apple started issuing warnings for libs that use the deprecated
UIWebView
. Firebase Authentication depends onFirAuth
that references this old apiIs is to be expected for Apple to start rejecting apps that use this api.
A commit has already been pushed to firebase auth repo
firebase/firebase-ios-sdk#3723
React native discussion
react-native-webview/react-native-webview#819
We should aim to push an updated dependency as soon as Firebase Auth releases a new version
Project Files
iOS
Click To Expand
ios/Podfile
:Environment
Click To Expand
react-native info
output:react-native-firebase
version you're using that has this issue:e.g. 5.4.3
Firebase
module(s) you're using that has the issue:e.g. Instance ID
TypeScript
?Y/N
Think
react-native-firebase
is great? Please consider supporting all of the project maintainers and contributors by donating via our Open Collective where all contributors can submit expenses. [Learn More]React Native Firebase
andInvertase
on Twitter for updates on the library.The text was updated successfully, but these errors were encountered: