-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: bump firebase sdk versions, add GoogleApi dep, use Android API29 #4122
Conversation
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/invertase/react-native-firebase/epqx1c6db |
…ep, use Android API29 This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29 Also: - cleans up the non-functional gradle wrapper files in the packages - centralizes all the gradle versioning to app/package.json (overrides still possible)
dc05f9f
to
39350b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, LGTM
Hi, Your changes from: To: causes crash while building:
Is there anything we need to add to our app's package.json? |
invertase#4122) * feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29 Also: - cleans up the non-functional gradle wrapper files in the packages - centralizes all the gradle versioning to app/package.json (overrides still possible) * fix(ios, versions): centralize firebase-ios-sdk versions
invertase#4122) * feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29 Also: - cleans up the non-functional gradle wrapper files in the packages - centralizes all the gradle versioning to app/package.json (overrides still possible) * fix(ios, versions): centralize firebase-ios-sdk versions
invertase#4122) * feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29 Also: - cleans up the non-functional gradle wrapper files in the packages - centralizes all the gradle versioning to app/package.json (overrides still possible) * fix(ios, versions): centralize firebase-ios-sdk versions
invertase#4122) * feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29 Also: - cleans up the non-functional gradle wrapper files in the packages - centralizes all the gradle versioning to app/package.json (overrides still possible) * fix(ios, versions): centralize firebase-ios-sdk versions
Description
This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29
Also:
Related issues
Fixes #3943
Release Summary
feat: bump firebase sdk versions, add GoogleApi dep, use Android API29
Checklist
Android
iOS
e2e
tests added or updated inpackages/\*\*/e2e
jest
tests added or updated inpackages/\*\*/__tests__
Test Plan
This is not supposed to be breaking in any way, although it does touch critical dependencies.
There are no breaking changes noted between the previous upstream SDK dependencies or Android APIs we relied on and the ones I moved to, and all the e2e tests work plus they work in my work project.
Worst case, all of them may be overridden.
This did finally expose the GoogleApisAvailability build error I was having though - it appears to be as simple as updating Android APIs to 29 / Gradle 4.0.1 - without the dependency on google's play store auth library, compiles fail, and it was noticed by someone else today.
I marked it as a feature release since it is not breaking but people should be aware the default SDKs changed (feature releases themselves, so transitively it seems to fit)
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter