Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bump firebase sdk versions, add GoogleApi dep, use Android API29 #4122

Merged
merged 3 commits into from
Aug 26, 2020

Conversation

mikehardy
Copy link
Collaborator

@mikehardy mikehardy commented Aug 22, 2020

Description

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:

  • cleans up the non-functional gradle wrapper files in the packages
  • centralizes all the gradle versioning to app/package.json (overrides still possible)

Related issues

Fixes #3943

Release Summary

feat: bump firebase sdk versions, add GoogleApi dep, use Android API29

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

This is not supposed to be breaking in any way, although it does touch critical dependencies.

There are no breaking changes noted between the previous upstream SDK dependencies or Android APIs we relied on and the ones I moved to, and all the e2e tests work plus they work in my work project.

Worst case, all of them may be overridden.

This did finally expose the GoogleApisAvailability build error I was having though - it appears to be as simple as updating Android APIs to 29 / Gradle 4.0.1 - without the dependency on google's play store auth library, compiles fail, and it was noticed by someone else today.

I marked it as a feature release since it is not breaking but people should be aware the default SDKs changed (feature releases themselves, so transitively it seems to fit)


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Aug 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/invertase/react-native-firebase/epqx1c6db
✅ Preview: https://react-native-firebase-git-update-test-app.invertase.vercel.app

@mikehardy mikehardy marked this pull request as draft August 22, 2020 03:54
…ep, use Android API29

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:
-  cleans up the non-functional gradle wrapper files in the packages
-  centralizes all the gradle versioning to app/package.json (overrides still possible)
@mikehardy mikehardy changed the title chore: update dependencies, test app WIP feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 Aug 26, 2020
@mikehardy mikehardy marked this pull request as ready for review August 26, 2020 03:11
@mikehardy mikehardy changed the title feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29 feat: bump firebase sdk versions, add GoogleApi dep, use Android API29 Aug 26, 2020
@mikehardy mikehardy requested a review from Salakar August 26, 2020 03:14
@mikehardy mikehardy changed the title feat: bump firebase sdk versions, add GoogleApi dep, use Android API29 feat: bump firebase sdk versions, add GoogleApi dep, use Android API29 Aug 26, 2020
@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Aug 26, 2020
Copy link
Member

@Salakar Salakar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, LGTM

@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Aug 26, 2020
@mikehardy mikehardy merged commit 728f418 into master Aug 26, 2020
@JiboStore
Copy link
Contributor

Hi,

Your changes from:
def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "25.5.0"

To:
def firebaseBomVersion = appPackageJson['sdkVersions']['android']['firebase']

causes crash while building:

* What went wrong:
A problem occurred evaluating project ':react-native-firebase_perf'.
> Cannot get property 'android' on null object

Is there anything we need to add to our app's package.json?

@mikehardy mikehardy deleted the update-test-app branch December 17, 2020 20:58
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
invertase#4122)

* feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:
-  cleans up the non-functional gradle wrapper files in the packages
-  centralizes all the gradle versioning to app/package.json (overrides still possible)

* fix(ios, versions): centralize firebase-ios-sdk versions
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
invertase#4122)

* feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:
-  cleans up the non-functional gradle wrapper files in the packages
-  centralizes all the gradle versioning to app/package.json (overrides still possible)

* fix(ios, versions): centralize firebase-ios-sdk versions
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
invertase#4122)

* feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:
-  cleans up the non-functional gradle wrapper files in the packages
-  centralizes all the gradle versioning to app/package.json (overrides still possible)

* fix(ios, versions): centralize firebase-ios-sdk versions
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
invertase#4122)

* feat(sdks, dependencies): bump firebase sdk versions, add GoogleApi dep, use Android API29

This bumps firebase-ios-sdk to 6.31.0, Android to 25.7.0, and Android compile/target to API29

Also:
-  cleans up the non-functional gradle wrapper files in the packages
-  centralizes all the gradle versioning to app/package.json (overrides still possible)

* fix(ios, versions): centralize firebase-ios-sdk versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test app out of date / possibly hiding compile failures
3 participants