Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] Bug Report Title - build.gradle crashes after recent PR: Cannot get property 'android' on null object #4153

Closed
1 of 10 tasks
JiboStore opened this issue Aug 27, 2020 · 1 comment
Labels
help: needs-triage Issue needs additional investigation/triaging. impact: build-error Behaviour causing build failure platform: android type: bug New bug report

Comments

@JiboStore
Copy link
Contributor

Issue

#4122

Your changes from:
def firebaseBomVersion = appPackageJson['sdkVersions'] ? appPackageJson['sdkVersions']['android']['firebase'] : "25.5.0"

To:
def firebaseBomVersion = appPackageJson['sdkVersions']['android']['firebase']

causes crash while building:

* What went wrong:
A problem occurred evaluating project ':react-native-firebase_perf'.
> Cannot get property 'android' on null object

Is there any reason for removing the checks?

Describe your issue here


Project Files

Javascript

Click To Expand

package.json:

# N/A

firebase.json for react-native-firebase v6:

# N/A

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:
# N/A

AppDelegate.m:

// N/A


Android

Click To Expand

Have you converted to AndroidX?

  • my application is an AndroidX application?
  • I am using android/gradle.settings jetifier=true for Android compatibility?
  • I am using the NPM package jetifier for react-native compatibility?

android/build.gradle:

// N/A

android/app/build.gradle:

// N/A

android/settings.gradle:

// N/A

MainApplication.java:

// N/A

AndroidManifest.xml:

<!-- N/A -->


Environment

Click To Expand

react-native info output:

 OUTPUT GOES HERE
  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • react-native-firebase version you're using that has this issue:
    • e.g. 5.4.3
  • Firebase module(s) you're using that has the issue:
    • e.g. Instance ID
  • Are you using TypeScript?
    • Y/N & VERSION


@JiboStore JiboStore added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Aug 27, 2020
@JiboStore JiboStore changed the title [🐛] Bug Report Title - CHANGE ME [🐛] Bug Report Title - build.gradle crashes: Cannot get property 'android' on null object Aug 27, 2020
@JiboStore JiboStore changed the title [🐛] Bug Report Title - build.gradle crashes: Cannot get property 'android' on null object [🐛] Bug Report Title - build.gradle crashes after recent PR: Cannot get property 'android' on null object Aug 27, 2020
@andersonaddo andersonaddo added impact: build-error Behaviour causing build failure platform: android labels Aug 27, 2020
@mikehardy
Copy link
Collaborator

@JiboStore I'm going to mark this as a duplicate of #4154 - we can focus effort there, but as mentioned there in the expected react-native-firebase installation the directories of app and all other packages are next to each other, so it should work. We'll figure out (over there) why that is not the case, but I do not want to revert to having version numbers all over the place so I want to keep the centralization change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help: needs-triage Issue needs additional investigation/triaging. impact: build-error Behaviour causing build failure platform: android type: bug New bug report
Projects
None yet
Development

No branches or pull requests

3 participants