-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛] Crashlytics 8.4.2 not collecting on iOS with pods 6.31? #4229
Comments
as mentioned on #3879 I'm also seeing same issue, anything I can do to help please let me know! |
Hi @rossjohnsonMP , Do you have any idea/step/trick to do so my ios crash report can appeared on Firebase Console? |
@abdullahizzuddiin that was more aimed at collaborators or maintainers, I can't help you as I'm in the same position :) |
Please confirm these things #3879 (comment)
For everyone that has confirmed all those things, we get a report of success. |
Dang, with that "Completed report submission", it seems like it all worked right? I mean, what else can we do 😅 - hopefully it is just a lag in reporting? There was one person that reported it took 15 hours once!?! Fantastic that you grabbed those logs though, I think they show everything is actually working. One thing I'll note (though let me say I do not think it is important here) is that |
I suspect this is caused by fabric migration. On 6.4.0 version, crashlytics (android and ios) worked wonderfully. on 7.* version, rnfb/crashlytics migrated to firebase/crashlytics. And I upgraded from 6.4.0 to 8.4.2. Maybe there is something wrong on my fabric migration. Any clue? |
I am not sure, it is possible to raise this with the firebase-ios-sdk repo. They do not readily take on issues when react-native-firebase is in use, but if you did a quick reproduction with your firebase credentials plist and a minimal amount of objective-c code that showed the problem you should be able to get attention (they probably have an example you could quickly clone and try?). There are other Fabric customers that reported an inability to see reports after migrating and I don't believe anyone has reported a resolution for it yet |
I've also generate new main.bundlejs. Old main.bundlejs still have code/configuration related to fabric. It still didn't worked. = = = anyone has tried to abandon old firebase project, and new fresh project with no fabric migration inside? what problem will be potentially occurred? |
exactly same issue here |
Hi @wddwycc, |
migrating from 6.4.0 to 8.4.2, enabled
The log says report completed, but nothing in my firebase dashboard |
This |
What a coincidence. I also sent a ticket to firebase support. Thanks @wddwycc |
Firebase support team has answered my ticket and they refused to check because I'm using 3rd party library --not directly using Firebase/Crashlytics |
I choose my words carefully @abdullahizzuddiin
https://github.com/firebase/quickstart-ios/blob/master/crashlytics/README.md |
Same here. |
Likewise. Not uploading symbols should not prevent crashes appearing. |
I did try this : https://firebase.google.com/docs/crashlytics/get-deobfuscated-reports to upload manually. ios/Pods/FirebaseCrashlytics/upload-symbols -gsp ios/MyApp/GoogleService-Info.plist -p ios ios/MyApp.app.dSYM.zip I'm gonna wait a few hours to see if it appears, otherwise I'm lost. |
Let me release the current work really quickly - it has been merged but not released. Update your crashlytics in about 30 minutes to the version I will generate and it may help. Adding -FIRDebugEnabled to your launch arguments in your build scheme in Xcode may be illuminating as well |
Thanks for the help, I’ll check it when it’s out. |
Thanks for the help, but unfortunately, it doesn't seem to work :/ My firebase.json: {
"react-native": {
"crashlytics_debug_enabled": true,
"crashlytics_auto_collection_enabled": true,
"crashlytics_disable_auto_disabler": true
}
}
My versions :
I've been looking so long at the |
Definitely do this, it (along with a step you need to take in order for it to work with a debugger attached) are detailed here https://firebase.google.com/docs/crashlytics/test-implementation?platform=ios I have to admit I find it easier to TestFlight a release build personally, but that's for ongoing testing, I understand during initial implementation debug crashes are quite useful |
I found a solution !! "@react-native-firebase/analytics": "^7.4.1",
"@react-native-firebase/app": "^8.3.0",
"@react-native-firebase/messaging": "^7.6.1",
"@react-native-firebase/crashlytics": "8.3.0", I'm just scared that I might introduce some breaking change (@mikehardy ?), otherwise it's all good for me. |
Interesting from exactly what to exactly what versions? Then we can bisect |
From this : "@react-native-firebase/analytics": "^7.6.2",
"@react-native-firebase/app": "^8.4.2",
"@react-native-firebase/crashlytics": "^8.4.4", <--
"@react-native-firebase/messaging": "^7.8.6", To that : "@react-native-firebase/analytics": "^7.4.1",
"@react-native-firebase/app": "^8.3.0",
"@react-native-firebase/crashlytics": "8.3.0", <--
"@react-native-firebase/messaging": "^7.6.1", |
How did it go with 8.4.2? There are only 2 changes in Crashlytics in the version range you just mentioned, and you removed both - curious how it goes with only removing the most recent change so you still have the change from 8.4.2 |
I was with the |
@mikehardy do we going to release any fix soon? |
@sbatikeri I don't recall you proposing a PR with a fix? There are explicit mentions above about what needs to be tested to find the problem, then we'll need a fix. I look forward to a PR, I have not had time myself |
I did that and works, but I've felt a little bad downgrading a lot of dependencies, I hope that this works correctly with the latest version soon |
@MiguelGrability you don't have to hope! You can do this:
And advance the issue by discovering the exact change, helping everyone out 🙏 |
After a large amount of pain and confusion I too can confirm that downgrading from:
to
as well as setting |
We don't need more information on environments, we need someone with some time to do the version bisect from 8.3.0 to 8.4.5 - as indicated there are really just 2 or 3 changes to consider, so it should be quick work but it hasn't been taken up yet Sorry this is continuing to sit out there and cause trouble for other developers but I'm out of time to drive it at the moment between apple-auth, this library, device-info, and my work project. We need help if someone has time 🙏 |
I did some test with later version, and it stop sending crash report from crashlytics 8.3.2, i've checked the difference between 8.3.0 and 8.3.2. I think this is the issue 6b136c3 , using |
@babeone it would be interesting to know if general crashes (as opposed to the "test crash" feature) still worked, as that was a specific area of change here. I'm surprised that caused a problem as it was pretty thoroughly researched and tested, but programming is always surprising. Thank you thank you for investigating, the answer should be in there somewhere... |
@mikehardy Yes, i've tried with 8.3.3 and it's the same as the 8.3.2, with |
Relevant comment from @JellyLu on the commit that changed crash style and may be the root cause here, pending testing/confirmation 2cbab5c#commitcomment-43192535
|
Hey guys, I've been silently tracking this issue and just wondering about the status of it. Looking at master 2dcaad5 has been merged which appears to fix this issue - is this correct or is there more to it than meets the eye? |
@se1exin we can always use more confirmation but it is my understanding that with the correct firebase.json settings and the most recent release, crashes should report on ios in debug and release - in other words, it's supposed to all be working now |
Thanks for the update @mikehardy - for what it's worth, I have updated my |
Updating all worked for me.
|
react-native-firebase/crashlytics to 8.4.11 solved! Thx you guys! |
Should check the peerDependence version of each module.
|
@7772 or move to v10+ where we moved to "One.True.Version" and they will no longer be versioned independently, eliminating all confusion |
Looks like this is solved; closing. |
[EDITED by @mikehardy 20200913]: it appears the pods 6.28 may work fine with our
@react-native-firebase/crashlytics@^8.4.2
, but that pods 6.31 does not. This is an area of active investigation. But you may try overriding pods to 6.28 for now. https://rnfirebase.io/#iosOriginal issue follows:
Issue
I just upgraded
@react-native-firebase/crashlytics
from6.4.0
to8.4.2
. Crash report from iOS didn't displayed on Firebase Console Dashboard.What I've Done
xschme
,project.pbxproj
,podfile
,podfile.lock
firebase.json
crashlytics().setCrashlyticsCollectionEnabled(true);
in app codecrashlytics().crash()
After all things i've done, nothing resulted to displaying error on my Firebase Console.
This log displayed immediately after app builded and ran on my phone.
Sometimes,
1 unsent reports are available. Checking for upload permission.
displayed on console. But, nothing happened after I triggercrashlytics().sendUnsentReports();
I also followed this suggestion. I added
to
Info.plist
and it gave result.we may highlighted
Automatic data collection is enabled.
but no crash appeared on firebase console.On device log, It displayed this error
Project Files
Javascript
Click To Expand
package.json
:firebase.json
for react-native-firebase v6:iOS
Click To Expand
ios/Podfile
:AppDelegate.m
:Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settings
jetifier=true
for Android compatibility?jetifier
for react-native compatibility?android/build.gradle
:// N/A
android/app/build.gradle
:// N/A
android/settings.gradle
:// N/A
MainApplication.java
:// N/A
AndroidManifest.xml
:<!-- N/A -->
Environment
Click To Expand
react-native info
output:react-native-firebase
version you're using that has this issue:Firebase
module(s) you're using that has the issue:e.g. Instance ID
TypeScript
?N
React Native Firebase
andInvertase
on Twitter for updates on the library.The text was updated successfully, but these errors were encountered: