Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[🐛] NPM package '@react-native-firebase/messaging' depends on '@react-native-firebase/app' v8.4.2 but found v8.4.3 #4283

Closed
lorenc-tomasz opened this issue Sep 19, 2020 · 26 comments · Fixed by #4330
Closed

[🐛] NPM package '@react-native-firebase/messaging' depends on '@react-native-firebase/app' v8.4.2 but found v8.4.3 #4283

lorenc-tomasz opened this issue Sep 19, 2020 · 26 comments · Fixed by #4330
Assignees
@mikehardy
Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report

Comments

@lorenc-tomasz
Copy link

NPM package '@react-native-firebase/messaging' depends on '@react-native-firebase/app' v8.4.2 but found v8.4.3
@lorenc-tomasz lorenc-tomasz added help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report labels Sep 19, 2020
@mikehardy

This comment has been minimized.

Sign in to view
@mikehardy mikehardy self-assigned this Sep 19, 2020
@mikehardy mikehardy added the Workflow: Needs Review Pending feedback or review from a maintainer. label Sep 19, 2020
@lorenc-tomasz

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@sangameshrently

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@ArrudaWillyan

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@ArrudaWillyan

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@lorenc-tomasz

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@mikehardy mikehardy mentioned this issue Sep 23, 2020
Closed
@daniyal-ahmed-khan

This comment has been minimized.

Sign in to view
@nonewcode

This comment has been minimized.

Sign in to view
@Odinwan

This comment has been minimized.

Sign in to view
@quyetthang122

This comment has been minimized.

Sign in to view
@daniyal-ahmed-khan

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@cxrod

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@mikehardy mikehardy mentioned this issue Sep 30, 2020
Merged
9 tasks
mikehardy added a commit that referenced this issue Sep 30, 2020
@mikehardy
fix(publish): never auto-cancel publish workflow
09c6744 
This is the one workflow where cancellation can become a real problem. Two publish actions are spawned for each workflow run (one is dispatched manually, the second is triggered), and if auto-cancellation is in the workflow then the second one kills the first one

Reference #4283
@mikehardy mikehardy mentioned this issue Sep 30, 2020
Merged
@mikehardy

This comment has been minimized.

Sign in to view
mikehardy added a commit that referenced this issue Sep 30, 2020
@mikehardy
fix(publish): never auto-cancel publish workflow (#4330)
61df91f 
This is the one workflow where cancellation can become a real problem. Two publish actions are spawned for each workflow run (one is dispatched manually, the second is triggered), and if auto-cancellation is in the workflow then the second one kills the first one

Reference #4283
@mikehardy

This comment has been minimized.

Sign in to view
This was referenced Oct 1, 2020
Closed
Merged
@Nehal-29

This comment has been minimized.

Sign in to view
@mikehardy

This comment has been minimized.

Sign in to view
@mikehardy mikehardy removed the Workflow: Needs Review Pending feedback or review from a maintainer. label Nov 26, 2020
@waleedshkt
Copy link

waleedshkt commented Jan 30, 2021 •
edited
Loading

Ran into similar versions non-compatibility issue too.
This is simply caused by different versions installed at different points in time. And during that period, newer (DEFAULT) versions got released.

Solution: re-install the packages with (correct) matching versions

@MalikNaser

This comment has been minimized.

Sign in to view
@mikehardy
Copy link
Collaborator

mikehardy commented May 14, 2021 •
edited
Loading

Always install a matching set of versions - we have worked hard to simplify this for everyone

https://invertase.io/blog/react-native-firebase-versioning

@MalikNaser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikehardy mikehardy

Labels
help: needs-triage Issue needs additional investigation/triaging. type: bug New bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(publish): never auto-cancel publish workflow invertase/react-native-firebase