-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔥[🐛] Crash - Using in-app-messaging (or remote-config) without analytics #4821
Comments
Hmm -
I have 1.3.2 for support lib and play services at 17.5.0 (both current as of this typing). Kotlin can be 1.4.21 and react-native at 0.63.4. appcompat is on 1.2.0 as well. The support lib being old is maybe related to the non-androidx design dependency? Either way looks like you're playing with fire there partially androidx converted, partially not crashlytics plugin is 2.4.1 and google-services is 4.3.4
looks like a remnant from react-native-firebase v5, this should not be necessary That along with kotlin and react-native itself are behind, I don't think these in particular will end well All of that is somewhat unrelated though. I think the error message is supposed to be more thorough and explain what component failed, My guess is that in-app-messaging has a dependency on analytics and if you add it, it will work? I'm actually not sure how you expect remote-config or in-app-messaging to function without analytics as they both indicate it is necessary: https://firebase.google.com/docs/in-app-messaging/get-started?platform=android I think that will get you moving, however it would be a bug here if we don't specify those are required - and I Just checked the docs, we don't. Pending confirmation that fixes your issue we can pursue communicating the required transitive dependency |
@mikehardy thank you. installing analytics solved this. we didn't check official firebase docs, only react-native-firebase. I guess the majority of RN developers did this, adding this is in the docs will help |
Really glad to hear that worked, I was going to be confused if it did not work :-) I hope you don't mind but I am going to change the title on this one now that the root cause seems identified, and I will leave it open to prompt the follow-on work Cheers |
…ency Visible in integration guides upstream Related #4821
…dependency Visible in integration guides upstream Related #4821
…ency Visible in integration guides upstream Related #4821
…ency Visible in integration guides upstream Related #4821
…dependency Visible in integration guides upstream Related #4821
…ency Visible in integration guides upstream Related #4821
Issue
Hello guys. We updated to firebase 10.5.0 (for app package and 10.5.1 for the other packages) and rollout in production. For the first time our play console registered this crash on opening the app. It impacted ~ 1k/20k users. It was something that we couldn't replicate with our devices & emulators.
This is the stack trace from play console
What we updated:
Then we got a more specific stacktrace from a beta tester:
Reached out to the tester and downgrade firebase versions from
package.json
to previous values. It works now for him.But I would not jump into conclusions as I researched this a lot. I'm not sure if it's a firebase problem(probably native implementation) or a cache problem with our project
Other issues i find related:
Project Files
Javascript
Click To Expand
package.json
:firebase.json
for react-native-firebase v6:iOS
Click To Expand
ios/Podfile
:# N/A
AppDelegate.m
:// N/A
Android
Click To Expand
Have you converted to AndroidX?
android/gradle.settings
jetifier=true
for Android compatibility?jetifier
for react-native compatibility?android/build.gradle
:android/app/build.gradle
:android/settings.gradle
:MainApplication.java
:AndroidManifest.xml
:Environment
Click To Expand
react-native info
output:react-native-firebase
version you're using that has this issue:10.5.0
Firebase
module(s) you're using that has the issue:Crashlytics, DynamicLinks, InAppMessaging, Messaging, RemoteConfig
TypeScript
?Y
React Native Firebase
andInvertase
on Twitter for updates on the library.The text was updated successfully, but these errors were encountered: