[IOS][LINKS] Apply new restorationHandler implementation #1778
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@Salakar this is universal linking issue we talked about with you earlier. Same one I opened react-native issue for facebook/react-native#22716
I basically applied same implementation as apple has documented here https://developer.apple.com/documentation/uikit/uiapplicationdelegate/1623072-application?language=objc
And this fixed issues I was having in XCode 10 / ios 12. I tested this on a real device. I was not able to test with earlier iOS versions, but judging by apple's documentation this should be supported by iOS 8+ and previous implementation used
Any
instead ofUIUserActivityRestoring
, so there shouldn't be any issues here as well. And finallyrestorationHandler
is not used as far as I can tell, it just needs to be passed in.Checklist
Android
iOS
e2e
tests added or updated in /tests/e2e/*Test Plan
Implement the change, check if it works on iOS devices that are running versions lower than 12. Has to be ran on a real device due to nature of simulator.
Release Plan
[IOS][ENHANCEMENT] [LINKS] - Updated universal link handling implementation for iOS 12
Think
react-native-firebase
is great? Please consider supporting the project with any of the below:React Native Firebase
andInvertase
on Twitter