Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade native Firebase SDK version #3663

Merged
merged 6 commits into from
May 22, 2020

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented May 18, 2020

Upgrade every package dependency to the latest Firebase SDK versions for iOS & Android.

@Salakar
Copy link
Member

Salakar commented May 18, 2020

As expected, an Instance ID test is failing on Android and an iOS Instance ID test is causing a app crash hence why the CI stage times out

@Salakar Salakar changed the title build(*): upgrade Firebase App dependency build(*): upgrade Firebase SDK dependencies May 18, 2020
@Salakar Salakar changed the title build(*): upgrade Firebase SDK dependencies build: upgrade Firebase SDK dependencies May 18, 2020
@Salakar
Copy link
Member

Salakar commented May 20, 2020

Result of debugging firebase.iid().delete(): Looks like an iOS SDK issue, stepped through all Firebase iOS SDK code and it seems to fail at point of clearing the keychain of previous tokens with an EXC_BAD_ACCESS issue but doesn't seem to crash the app and just causes it to hang resolving the handler.

We'll just mark this as a known issue for now as one method failing shouldn't hold up all other modules - not much else we can do; we'll work on a vanilla iOS project reproduction of the issue and raise the issue on the Firebase iOS SDK repo.

@russellwheatley russellwheatley marked this pull request as ready for review May 22, 2020 15:43
@russellwheatley russellwheatley requested a review from Salakar May 22, 2020 15:43
@Salakar Salakar changed the title build: upgrade Firebase SDK dependencies feat: upgrade native Firebase SDK version May 22, 2020
@Salakar Salakar merged commit 4db9dbc into master May 22, 2020
stefkampen pushed a commit to stefkampen/react-native-firebase that referenced this pull request Jun 6, 2020
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
@mikehardy mikehardy deleted the @russell/upgrade-app-versions branch December 17, 2020 21:00
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
Updated Firebase Android SDK BoM version to 25.3.1 (from 24.1.0) and iOS SDK to 6.25.0 (from 6.13.0).

[publish]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants