Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: update test project #3815

Merged
merged 2 commits into from
Jun 22, 2020
Merged

tests: update test project #3815

merged 2 commits into from
Jun 22, 2020

Conversation

mikehardy
Copy link
Collaborator

Description

The iOS test setup had steps that could be combined, additionally when you went to update pods FirebaseFirestore pre-compiled framework is pinned to master, so you have to bump the SDK in use to 6.27.0

This combines two test-related pod install steps to one, and moves the SDK so the install works

Additionally there was a test failing locally which I had to disable before local iOS tests worked - it's the separate second commit in case that's unacceptable I can back it out - it was one yak shave too far to fix it

Related issues

Release Summary

tests: tests:ios:pod:install does full update, use SDK 6.27.0

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

The documentation requested a pod install that failed without using
current (since FirebaseFirestore:master moved on and deps didn't match)

Additionally, it did not fully update and there was another command
requested for iOS tests

This change allows the single command to work and succeed now
this is passing in CI, so I'm not sure about this commit but I had
to disable the test in order for local testing to work on iOS
@mikehardy
Copy link
Collaborator Author

Android e2e failed due to remoteconfig().fetch() throttling:

  1) remoteConfig()
       fetch()
         with expiration provided:
     NativeFirebaseError: [remoteConfig/throttled] fetch() operation cannot be completed successfully, due to throttling.

And this doesn't touch android at all so 🤷

@mikehardy
Copy link
Collaborator Author

Got this through E2E today too, I think it's good to go

@russellwheatley
Copy link
Member

This looks good to me, but I'll defer to @Salakar on this one, as I'm not confident of my understanding of cocoapods.

@Salakar Salakar changed the title Test updates CTest updates Jun 22, 2020
@Salakar Salakar changed the title CTest updates tests: update test project Jun 22, 2020
@Salakar Salakar merged commit 5560cba into invertase:master Jun 22, 2020
This was referenced Jun 22, 2020
@mikehardy mikehardy deleted the test-updates branch August 12, 2020 03:33
andersondanilo pushed a commit to vixtech/react-native-firebase that referenced this pull request Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants