Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use latest android & ios Firebase SDKs version #3956

Merged
merged 10 commits into from
Jul 24, 2020

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jul 16, 2020

addresses Mike's issue: #3943

Description

  • Updated Gradle version to latest 6.5.1 for each package.
  • Updated Android Gradle plugin to 4.0.0 for each package.
  • Updated buildTools to version 29.0.2 for tests android/build.gradle, minimum required for latest Android Gradle plugin.
  • Ran pod update within tests/ios to upgrade pods based on what is allowed according to Podfile and also to upgrade the GoogleUtilities pods to patched working version 6.7.1 (6.7 was a recently released broken version used by Firebase iOS SDK)
  • Updated Android Crashlytics SDK for tests.
  • Updated iOS SDK to 6.28.1

Related issues

Release Summary

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@russellwheatley russellwheatley changed the title chore(*, android * ios): version updates chore(*, android * ios): version updates [WIP] Jul 16, 2020
@russellwheatley russellwheatley changed the title chore(*, android * ios): version updates [WIP] chore(*, android * ios): version & test project updates [WIP] Jul 16, 2020
@russellwheatley russellwheatley changed the title chore(*, android * ios): version & test project updates [WIP] chore(*, android, ios): version & test project updates [WIP] Jul 16, 2020
tests/ios/Podfile.lock Outdated Show resolved Hide resolved
@mikehardy
Copy link
Collaborator

Hell good sir - as mentioned on the issue, happy to collaborate to flush out whatever is causing android compile errors for me. The IID one is obvious (it's just not versioned in the BoM, so....) but that GoogleApiAvailability thing is really odd - don't want anyone else to compile-fail on Android first thing, terrible DX

@russellwheatley russellwheatley changed the title chore(*, android, ios): version & test project updates [WIP] chore:, android, ios): version & test project updates [WIP] Jul 17, 2020
@russellwheatley russellwheatley changed the title chore:, android, ios): version & test project updates [WIP] chore: android & ios version & test project updates Jul 17, 2020
@mikehardy
Copy link
Collaborator

Well dang. Worked just fine it seems. With the demo script at least it's all built from scratch each time so the answer is in there somewhere, what the heck is going on...

@russellwheatley russellwheatley marked this pull request as ready for review July 17, 2020 15:43
@Salakar Salakar changed the title chore: android & ios version & test project updates feat: use latest android & ios Firebase SDKs version Jul 24, 2020
@russellwheatley russellwheatley merged commit e7b4bb3 into master Jul 24, 2020
@russellwheatley russellwheatley deleted the @russell/version-updates branch July 24, 2020 12:11
hmhm2292 pushed a commit to hmhm2292/react-native-firebase that referenced this pull request Jul 13, 2021
* chore(*): version upgrades

* chore(*, ios): update GoogleUtilities test/ios

* chore(_,ios): update pod lock

* chore(crashlytics, android): update SDK for tests

* chore: move google-services plugin for gradle

* chore: ios sdk upgrade

* chore: update test Podfile.lock
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
* chore(*): version upgrades

* chore(*, ios): update GoogleUtilities test/ios

* chore(_,ios): update pod lock

* chore(crashlytics, android): update SDK for tests

* chore: move google-services plugin for gradle

* chore: ios sdk upgrade

* chore: update test Podfile.lock
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Aug 9, 2021
* chore(*): version upgrades

* chore(*, ios): update GoogleUtilities test/ios

* chore(_,ios): update pod lock

* chore(crashlytics, android): update SDK for tests

* chore: move google-services plugin for gradle

* chore: ios sdk upgrade

* chore: update test Podfile.lock
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this pull request Sep 15, 2021
* chore(*): version upgrades

* chore(*, ios): update GoogleUtilities test/ios

* chore(_,ios): update pod lock

* chore(crashlytics, android): update SDK for tests

* chore: move google-services plugin for gradle

* chore: ios sdk upgrade

* chore: update test Podfile.lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants